[GitHub] [pinot] richardstartin commented on pull request #8535: add scalar function for cast so it can be calculated at compile time

[GitBox <gi...@apache.org>]

richardstartin commented on PR #8535:
URL: https://github.com/apache/pinot/pull/8535#issuecomment-1098820054

   > Currently `CastTransformFunction` doesn't support multi-valued column casting. We should keep the scalar function and transform function consistent (either both support MV or both not support MV). IMO multi-value handling is a little bit tricky because of the array type (primitive vs boxed), and we should add some queries test to ensure it works end-to-end and covers ingestion, compilation, aggregation and post-aggregation. I'd suggest first adding the basic support for SV, and then having a separate PR to add the MV support
   
   I agree that dropping MV support would simplify this a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org