You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ariel Weisberg (JIRA)" <ji...@apache.org> on 2015/12/04 18:33:11 UTC

[jira] [Commented] (CASSANDRA-10816) Explicitly handle SSL handshake errors during connect()

    [ https://issues.apache.org/jira/browse/CASSANDRA-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041821#comment-15041821 ] 

Ariel Weisberg commented on CASSANDRA-10816:
--------------------------------------------

I only made a 3.0 branch just to get the tests running. Will address fix versions after review.
|[3.0 code|https://github.com/apache/cassandra/compare/cassandra-3.0...aweisberg:CASSANDRA-10816?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10816-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10816-dtest/]|

> Explicitly handle SSL handshake errors during connect()
> -------------------------------------------------------
>
>                 Key: CASSANDRA-10816
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10816
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>             Fix For: 2.1.x, 2.2.x
>
>
> Diagnosing internode SSL issues can be a problem as any messaging {{IOException}} before this patch is just logged to debug, which is likely not enabled in most cases. Logs will just show nothing in case of any problems with SSL certs. 
> Also the implemented retry semantics in {{OutboundTcpConnection}} will not make much sense for SSL handshake errors and will cause unnecessary load for both peers.
> The proposed patch will explicitly catch {{SSLHandshakeException}}, log them to error and abort connect().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)