You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/06 16:16:46 UTC
[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1725:
[CALCITE-3694] Implement SINH function
XuQianJin-Stars opened a new pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725
As illustrated in [CALCITE-3694](https://issues.apache.org/jira/browse/CALCITE-3694)
# SINH function returns the hyperbolic sine of a number.
select sinh(1);
+--------------------+
| EXPR$0 |
+--------------------+
| 1.1752011936438014 |
+--------------------+
(1 row)
!ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] 34venu edited a comment on issue #1725: [CALCITE-3694]
Implement SINH function
Posted by GitBox <gi...@apache.org>.
34venu edited a comment on issue #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#issuecomment-571948449
After modifying the relevant java files for sinh function I am getting this error
No match found for function signature SINH(<NUMERIC>)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request
#1725: [CALCITE-3694] Implement SINH function
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#discussion_r363768476
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1705,6 +1705,7 @@ public SqlOperandCountRange getOperandCountRange() {
OperandTypes.NUMERIC,
SqlFunctionCategory.NUMERIC);
+ public static final SqlFunction SINH = SqlLibraryOperators.SINH;
Review comment:
well , Let change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] chunweilei merged pull request #1725: [CALCITE-3694]
Implement SINH function
Posted by GitBox <gi...@apache.org>.
chunweilei merged pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] ritesh-kapoor commented on a change in pull request
#1725: [CALCITE-3694] Implement SINH function
Posted by GitBox <gi...@apache.org>.
ritesh-kapoor commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#discussion_r365281586
##########
File path: site/_docs/reference.md
##########
@@ -2325,6 +2325,7 @@ semantics.
| o | RTRIM(string) | Returns *string* with all blanks removed from the end
| m p | SHA1(string) | Calculates a SHA-1 hash value of *string* and returns it as a hex string
| m o p | SOUNDEX(string) | Returns the phonetic representation of *string*; throws if *string* is encoded with multi-byte encoding such as UTF-8
+| o | SINH(numeric) | Returns the hyperbolic sine of *numeric*
Review comment:
Lets maintain alphabetical order :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] 34venu removed a comment on issue #1725: [CALCITE-3694]
Implement SINH function
Posted by GitBox <gi...@apache.org>.
34venu removed a comment on issue #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#issuecomment-571948449
After modifying the relevant java files for sinh function I am getting this error
No match found for function signature SINH(<NUMERIC>)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] 34venu commented on issue #1725: [CALCITE-3694] Implement
SINH function
Posted by GitBox <gi...@apache.org>.
34venu commented on issue #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#issuecomment-571948449
After modifying the relevant java files for sinh function I am getting the this error
No match found for function signature SINH(<NUMERIC>)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1725:
[CALCITE-3694] Implement SINH function
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#discussion_r363620575
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1705,6 +1705,7 @@ public SqlOperandCountRange getOperandCountRange() {
OperandTypes.NUMERIC,
SqlFunctionCategory.NUMERIC);
+ public static final SqlFunction SINH = SqlLibraryOperators.SINH;
Review comment:
is `SINH` part of standard SQL ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request
#1725: [CALCITE-3694] Implement SINH function
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#discussion_r364143342
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1705,6 +1705,7 @@ public SqlOperandCountRange getOperandCountRange() {
OperandTypes.NUMERIC,
SqlFunctionCategory.NUMERIC);
+ public static final SqlFunction SINH = SqlLibraryOperators.SINH;
Review comment:
> Well, I think if it's not part of standard SQL, it should not be in `SqlStdOperatorTable`
hi @yanlin-Lynn I have changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1725:
[CALCITE-3694] Implement SINH function
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#discussion_r363654792
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1705,6 +1705,7 @@ public SqlOperandCountRange getOperandCountRange() {
OperandTypes.NUMERIC,
SqlFunctionCategory.NUMERIC);
+ public static final SqlFunction SINH = SqlLibraryOperators.SINH;
Review comment:
Well, I think if it's not part of standard SQL, it should not be in `SqlStdOperatorTable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request
#1725: [CALCITE-3694] Implement SINH function
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#discussion_r363635479
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1705,6 +1705,7 @@ public SqlOperandCountRange getOperandCountRange() {
OperandTypes.NUMERIC,
SqlFunctionCategory.NUMERIC);
+ public static final SqlFunction SINH = SqlLibraryOperators.SINH;
Review comment:
> is `SINH` part of standard SQL ?
Actually I want to support standard SQL at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request
#1725: [CALCITE-3694] Implement SINH function
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #1725: [CALCITE-3694] Implement SINH function
URL: https://github.com/apache/calcite/pull/1725#discussion_r363768476
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -1705,6 +1705,7 @@ public SqlOperandCountRange getOperandCountRange() {
OperandTypes.NUMERIC,
SqlFunctionCategory.NUMERIC);
+ public static final SqlFunction SINH = SqlLibraryOperators.SINH;
Review comment:
well , Let change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services