[jira] [Commented] (SOLR-5825) Separate http request creation and execution in SolrJ

["Steven Bower (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923520#comment-13923520 ] 

Steven Bower commented on SOLR-5825:
------------------------------------

Btw, this patch is fully backwards compatible as it leaves the existing request method signature alone and simply changes the internals to call 2 new functions.

> Separate http request creation and execution in SolrJ
> -----------------------------------------------------
>
>                 Key: SOLR-5825
>                 URL: https://issues.apache.org/jira/browse/SOLR-5825
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Steven Bower
>         Attachments: SOLR-5825.patch
>
>
> In order to implement some custom behaviors I split the request() method in HttpSolrServer into 2 distinct method createMethod() and executeMethod(). This allows for customization of either/both of these phases vs having it in a single function.
> In my use case I extended HttpSolrServer to support client side timeouts (so_timeout, connectTimeout and request timeout).. without duplicating the code in request() I couldn't accomplish..



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org