You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/11 15:00:51 UTC
[GitHub] [flink] fapaul opened a new pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
fapaul opened a new pull request #18330:
URL: https://github.com/apache/flink/pull/18330
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This PR marks the second part of API changes of FLIP-191 https://issues.apache.org/jira/browse/FLINK-25555 introducing the interfaces used to execute arbitrary topologies before and after the sink writer and committer.
The only relevant change is ff760683fa8bc56fb6c72811cab6a203405218ef because the PR currently depends on #18302 and #18325.
## Brief change log
- Introduce mixin interfaces to construct a topology sink
- Add committable message classes to clarify the exchange
## Verifying this change
Primarily the PR consists of API changes
- Added a test to verify the serialization of the committable messages
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b38cd1a42911fdb19cab028b52603be5c602a94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321)
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784731046
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableMessageTypeInfo.java
##########
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.connector.sink2.Committer;
+import org.apache.flink.api.connector.sink2.SinkWriter;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.core.io.SimpleVersionedSerializerTypeSerializerProxy;
+import org.apache.flink.util.function.SerializableSupplier;
+
+import java.util.Objects;
+
+/** The message send from {@link SinkWriter} to {@link Committer}. */
+@Experimental
+public class CommittableMessageTypeInfo<CommT> extends TypeInformation<CommittableMessage<CommT>> {
+
+ private final SerializableSupplier<SimpleVersionedSerializer<CommT>>
+ committableSerializerFactory;
+
+ private CommittableMessageTypeInfo(
+ SerializableSupplier<SimpleVersionedSerializer<CommT>> committableSerializerFactory) {
+ this.committableSerializerFactory = committableSerializerFactory;
+ }
+
+ /**
+ * Returns the type information based on the serializer for a {@link CommittableMessage}.
+ *
+ * @param committableSerializerFactory factory to create the serializer for a {@link
+ * CommittableMessage}
+ * @param <CommT> type of the committable
+ * @return
+ */
+ public static <CommT>
+ TypeInformation<CommittableMessage<CommT>> forCommittableSerializerFactory(
Review comment:
I renamed the method to `of` because `for` is a reserved keyword and cannot be used as method name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff760683fa8bc56fb6c72811cab6a203405218ef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1011964785
Very thanks @fapaul for drafting the PR! I'll have a look~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1012608343
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b38cd1a42911fdb19cab028b52603be5c602a94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff760683fa8bc56fb6c72811cab6a203405218ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269)
* bc8479a4942dc0319b0e81504673d8fe2a5bb949 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010057465
@gaoyunhaii sorry for pinging again but it would be great to also hear your opinion on the interfaces :) ff76068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff760683fa8bc56fb6c72811cab6a203405218ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784393519
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+
+import javax.annotation.Nullable;
+
+import java.util.OptionalLong;
+
+/**
+ * This class tracks the information about committables belonging to one checkpoint coming from one
+ * subtask.
+ *
+ * <p>It is sent to down-stream consumers to depict the progress of the committing process.
+ *
+ * @param <CommT> type of the committable
+ */
+@Experimental
+public class CommittableSummary<CommT> implements CommittableMessage<CommT> {
Review comment:
It seems that `<CommT>` is unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18330:
URL: https://github.com/apache/flink/pull/18330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784386592
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableMessageTypeInfo.java
##########
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.connector.sink2.Committer;
+import org.apache.flink.api.connector.sink2.SinkWriter;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.core.io.SimpleVersionedSerializerTypeSerializerProxy;
+import org.apache.flink.util.function.SerializableSupplier;
+
+import java.util.Objects;
+
+/** The message send from {@link SinkWriter} to {@link Committer}. */
+@Experimental
+public class CommittableMessageTypeInfo<CommT> extends TypeInformation<CommittableMessage<CommT>> {
+
+ private final SerializableSupplier<SimpleVersionedSerializer<CommT>>
+ committableSerializerFactory;
+
+ private CommittableMessageTypeInfo(
+ SerializableSupplier<SimpleVersionedSerializer<CommT>> committableSerializerFactory) {
+ this.committableSerializerFactory = committableSerializerFactory;
+ }
+
+ /**
+ * Returns the type information based on the serializer for a {@link CommittableMessage}.
+ *
+ * @param committableSerializerFactory factory to create the serializer for a {@link
+ * CommittableMessage}
+ * @param <CommT> type of the committable
+ * @return
+ */
+ public static <CommT>
+ TypeInformation<CommittableMessage<CommT>> forCommittableSerializerFactory(
Review comment:
NIT:
public static <CommT>
TypeInformation<CommittableMessage<CommT>> for(SerializableSupplier<SimpleVersionedSerializer<CommT>>
committableSerializerFactory)
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+
+import javax.annotation.Nullable;
+
+import java.util.OptionalLong;
+
+/**
+ * This class tracks the information about committables belonging to one checkpoint coming from one
+ * subtask.
+ *
+ * <p>It is sent to down-stream consumers to depict the progress of the committing process.
+ *
+ * @param <CommT> type of the committable
+ */
+@Experimental
+public class CommittableSummary<CommT> implements CommittableMessage<CommT> {
Review comment:
It seems that <CommT> is unused.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableMessageTypeInfo.java
##########
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.connector.sink2.Committer;
+import org.apache.flink.api.connector.sink2.SinkWriter;
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.core.io.SimpleVersionedSerializerTypeSerializerProxy;
+import org.apache.flink.util.function.SerializableSupplier;
+
+import java.util.Objects;
+
+/** The message send from {@link SinkWriter} to {@link Committer}. */
Review comment:
java doc is the same as the interface CommittableMessage<CommT>
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+
+import javax.annotation.Nullable;
+
+import java.util.OptionalLong;
+
+/**
+ * This class tracks the information about committables belonging to one checkpoint coming from one
+ * subtask.
+ *
+ * <p>It is sent to down-stream consumers to depict the progress of the committing process.
+ *
+ * @param <CommT> type of the committable
+ */
+@Experimental
+public class CommittableSummary<CommT> implements CommittableMessage<CommT> {
+ private final int subtaskId;
+ /** May change after recovery. */
+ private final int numberOfSubtasks;
+
+ @Nullable private final Long checkpointId;
+ /** The number of committables coming from the given subtask in the particular checkpoint. */
+ private final int numberOfCommittables;
+ /** The number of committables that have not been successfully committed. */
+ private final int numberOfPendingCommittables;
+ /** The number of committables that are not retried and have been failed. */
+ private final int numberOfFailedCommittables;
+
+ public CommittableSummary(
Review comment:
Providing builder would be helpful for users to avoid human mistakes, since there are 5 parameters of type int in the method signature.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/WithPostCommitTopology.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+import org.apache.flink.api.connector.sink2.Committer;
+import org.apache.flink.api.connector.sink2.TwoPhaseCommittingSink;
+import org.apache.flink.streaming.api.datastream.DataStream;
+
+/**
+ * Allows expert users to implement a custom topology after {@link Committer}.
+ *
+ * <p>It is recommended to use immutable committables because mutating committables can have
+ * unexpected side-effects.
+ */
+@Experimental
+public interface WithPostCommitTopology<InputT, CommT>
+ extends TwoPhaseCommittingSink<InputT, CommT> {
+
+ /**
+ * Adds a custom post-commit topology where all committables can be processed.
+ *
+ * <p>It is strongly recommended to keep this pipeline stateless such that batch and streaming
+ * modes do not require special cases.
+ *
+ * <p>All operations need to be idempotent: on recovery, any number of committables may be
+ * replayed that have already been committed. It's mandatory that these committables have no
+ * effect on the external system.
+ */
Review comment:
```suggestion
* @param committables the stream of committables.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1012277251
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc8479a4942dc0319b0e81504673d8fe2a5bb949 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310)
* 8b38cd1a42911fdb19cab028b52603be5c602a94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010052412
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ff760683fa8bc56fb6c72811cab6a203405218ef (Tue Jan 11 15:05:06 UTC 2022)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29439",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29439)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff760683fa8bc56fb6c72811cab6a203405218ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b38cd1a42911fdb19cab028b52603be5c602a94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321)
* 44d681f57f188a88ffb08fc980701c517bb91981 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff760683fa8bc56fb6c72811cab6a203405218ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269)
* bc8479a4942dc0319b0e81504673d8fe2a5bb949 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784741404
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+
+import javax.annotation.Nullable;
+
+import java.util.OptionalLong;
+
+/**
+ * This class tracks the information about committables belonging to one checkpoint coming from one
+ * subtask.
+ *
+ * <p>It is sent to down-stream consumers to depict the progress of the committing process.
+ *
+ * @param <CommT> type of the committable
+ */
+@Experimental
+public class CommittableSummary<CommT> implements CommittableMessage<CommT> {
+ private final int subtaskId;
+ /** May change after recovery. */
+ private final int numberOfSubtasks;
+
+ @Nullable private final Long checkpointId;
+ /** The number of committables coming from the given subtask in the particular checkpoint. */
+ private final int numberOfCommittables;
+ /** The number of committables that have not been successfully committed. */
+ private final int numberOfPendingCommittables;
+ /** The number of committables that are not retried and have been failed. */
+ private final int numberOfFailedCommittables;
+
+ public CommittableSummary(
Review comment:
I agree that having 5 parameters with the same type is not ideal but I also do not like a builder because for me a builder implies that you have many nullable fields or defaults.
On the other hand, I do not expect users to instantiate this class because the main intention is that they can consume the message sent by the writer/committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29439",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29439)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc8479a4942dc0319b0e81504673d8fe2a5bb949 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc8479a4942dc0319b0e81504673d8fe2a5bb949 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310)
* 8b38cd1a42911fdb19cab028b52603be5c602a94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784116528
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableMessage.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+
+import java.util.OptionalLong;
+
+/** The message send from {@link SinkWriter} to {@link Committer}. */
Review comment:
The two links would need imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
}, {
"hash" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430",
"triggerID" : "3f68d9e0ff64526886459be5b8210346848c56a3",
"triggerType" : "PUSH"
}, {
"hash" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29439",
"triggerID" : "db5e6c006d4f16bf49163cfcec25a403d4c15531",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
* 3f68d9e0ff64526886459be5b8210346848c56a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29430)
* db5e6c006d4f16bf49163cfcec25a403d4c15531 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29439)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18330:
URL: https://github.com/apache/flink/pull/18330#discussion_r784738375
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableSummary.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.connector.sink2;
+
+import org.apache.flink.annotation.Experimental;
+
+import javax.annotation.Nullable;
+
+import java.util.OptionalLong;
+
+/**
+ * This class tracks the information about committables belonging to one checkpoint coming from one
+ * subtask.
+ *
+ * <p>It is sent to down-stream consumers to depict the progress of the committing process.
+ *
+ * @param <CommT> type of the committable
+ */
+@Experimental
+public class CommittableSummary<CommT> implements CommittableMessage<CommT> {
Review comment:
Yes, that's true but we cannot easily remove it. The only option is to remove the generic type from the CommittableMessage interface unfortunately, this makes consuming the DataStream from the topology i.e.
`WithPreCommitTopology#addTopology` very difficuly because you do not have the type information anymore of the generic type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18330: [FLINK-25570][streaming] Add topology extension points to Sink V2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18330:
URL: https://github.com/apache/flink/pull/18330#issuecomment-1010053336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29269",
"triggerID" : "ff760683fa8bc56fb6c72811cab6a203405218ef",
"triggerType" : "PUSH"
}, {
"hash" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29310",
"triggerID" : "bc8479a4942dc0319b0e81504673d8fe2a5bb949",
"triggerType" : "PUSH"
}, {
"hash" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29321",
"triggerID" : "8b38cd1a42911fdb19cab028b52603be5c602a94",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "44d681f57f188a88ffb08fc980701c517bb91981",
"triggerType" : "PUSH"
}, {
"hash" : "44d681f57f188a88ffb08fc980701c517bb91981",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371",
"triggerID" : "1012277251",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 44d681f57f188a88ffb08fc980701c517bb91981 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org