[GitHub] [lucene-solr] jpountz commented on pull request #1541: RegExp - add case insensitive matching option

[GitBox <gi...@apache.org>]

jpountz commented on pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#issuecomment-637503848


   @markharwood Java's case-insensitivity flag is indeed a bit mask flag passed to the constructor, but my comment was more about the fact that the current flags on RegExp are about what operators are supported, while the bit you are adding controls how matching works. So in my opinion, it should be a different constructor argument (boolean or other bit set depending on whether we're seeing other desirable ways to control how matching works). We could merge both bitsets internally if that makes things easier, my concern is only about the API.
   
   I don't have an opinion about the RegExp split, but I don't feel bad about propagating information recursively like in your PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org