You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/30 02:04:02 UTC

[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1480: fix:sanitize log output when exposing sensitive values

lingsamuel commented on code in PR #1480:
URL: https://github.com/apache/apisix-ingress-controller/pull/1480#discussion_r1035457272


##########
cmd/ingress/ingress.go:
##########
@@ -129,9 +129,12 @@ the apisix cluster and others are created`,
 
 			log.Info("version:\n", version.Long())
 
-			data, err := json.MarshalIndent(cfg, "", "\t")
+			// We should make sure that the cfg that's logged out is sanitized.
+			logCfg := cfg

Review Comment:
   `cfg` here is a pointer, so we need to dereference it or it will be changed globally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org