You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/01/31 19:08:01 UTC
[jira] [Commented] (IMPALA-7333) Remove MarkNeedsDeepCopy from
Aggregation and Hash Join Nodes
[ https://issues.apache.org/jira/browse/IMPALA-7333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757640#comment-16757640 ]
ASF subversion and git services commented on IMPALA-7333:
---------------------------------------------------------
Commit 6214d2d81236695a9e606634dbeebdbbbccf3847 in impala's branch refs/heads/master from Lars Volker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6214d2d ]
IMPALA-8140: Fix use-after-poison in grouping aggregator
IMPALA-7333 changed the memory transfer semantics to move memory when
attaching it to the output batch instead of copying it. This caused a
use-after-poison when the cleaning up the hash tables during the call to
Close(). To fix this, we now clean up the hash table before closing the
output row stream.
Testing: added a test to aggregation.test
Change-Id: Id23cd1e2fc5e003e3c9e3503436621a76d49559d
Reviewed-on: http://gerrit.cloudera.org:8080/12298
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Remove MarkNeedsDeepCopy from Aggregation and Hash Join Nodes
> -------------------------------------------------------------
>
> Key: IMPALA-7333
> URL: https://issues.apache.org/jira/browse/IMPALA-7333
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Labels: resource-management
> Fix For: Impala 3.1.0
>
>
> The main part of this is fixing BufferedTupleStream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org