You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/29 10:37:35 UTC
[GitHub] [arrow] nevi-me opened a new pull request #9041: ARROW-11063: [Rust] [Breaking] Validate null counts when building arrays
nevi-me opened a new pull request #9041:
URL: https://github.com/apache/arrow/pull/9041
Removes the null_count() function, forcing the builder to always validate the null count.
This breaks existing code that provides null counts, with the required action being to remove that code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9041: ARROW-11063: [Rust] [Breaking] Validate null counts when building arrays
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9041:
URL: https://github.com/apache/arrow/pull/9041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9041: ARROW-11063: [Rust] [Breaking] Validate null counts when building arrays
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9041:
URL: https://github.com/apache/arrow/pull/9041#issuecomment-752033070
https://issues.apache.org/jira/browse/ARROW-11063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9041: ARROW-11063: [Rust] [Breaking] Validate null counts when building arrays
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9041:
URL: https://github.com/apache/arrow/pull/9041#issuecomment-752490751
🤦 Sorry @nevi-me -- I also have a PR here to fix it: https://github.com/apache/arrow/pull/9046
I think it is blocking other PRs so I will merge https://github.com/apache/arrow/pull/9046 as soon as it is green. cc @mqy -- thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9041: ARROW-11063: [Rust] [Breaking] Validate null counts when building arrays
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9041:
URL: https://github.com/apache/arrow/pull/9041#issuecomment-752266447
There's a `rustfmt` lint that's failed on my CI run, I didn't see it till now. I'm using those new macbooks while I'm away from home, so I don't have the `stable` toolchain yet.
May someone who works on the next PR, fix the error for me :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9041: ARROW-11063: [Rust] [Breaking] Validate null counts when building arrays
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9041:
URL: https://github.com/apache/arrow/pull/9041#issuecomment-752413596
@nevi-me format in this way should avoid the problem
I have fixed it in https://github.com/apache/arrow/pull/9025
Also I'm thinking about add `cargo +nightly-2020-11-24-x86_64 fmt` to pre-commit.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org