[jira] [Commented] (THRIFT-762) Cocoa library won't compile on Mac OS X

["Jake Farrell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276412#comment-13276412 ] 

Jake Farrell commented on THRIFT-762:
-------------------------------------

Hey Andrew, I would just go with 10.6 but there is all ready checks in place for NSStreamDelegate, see transport/TSocketClient.h so use a similar approach. I will help with making a framework, will create a separate ticket for it
                
> Cocoa library won't compile on Mac OS X
> ---------------------------------------
>
>                 Key: THRIFT-762
>                 URL: https://issues.apache.org/jira/browse/THRIFT-762
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Library
>    Affects Versions: 0.2, 0.3
>         Environment: Mac OS X Snow Leopard 10.6, Mac OS X Leopard 10.5
>            Reporter: Jeremy Fergason
>            Assignee: Andrew McGeachie
>         Attachments: build_on_osx.patch
>
>
> The cocoa library will not compile for Objective-C Cocoa applications on Mac OS X because it tries to include <CFNetwork/CFSocketStream.h> in transport/TSocketClient.m.  This should be a pound-define that includes <CoreServices/CoreServices.h> if being compiled on Mac OS X or <CFNetwork/CFNetwork.h> if being compiled for iPhone OS.
> Also, the Mac OS X build will give a warning because the NSStreamDelegate protocol is not implemented in transport/TNSStreamTransport.{h,m}
> I have attached a patch to fix both issues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira