You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by hanm <gi...@git.apache.org> on 2017/01/23 18:33:28 UTC
[GitHub] zookeeper pull request #154: ZOOKEEPER-2672: Remove CHANGE.txt.
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/154
ZOOKEEPER-2672: Remove CHANGE.txt.
The CHANGE.txt is already not the source of truth of what's changed after we migrating to git - most of the git commits in recent couple of months don't update CHANGE.txt. The option of updating CHANGE.txt during commit flow automatically is none trivial, and do that manually is cumbersome and error prone.
The consensus is we would rely on source control revision logs instead of CHANGE.txt moving forward; see https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for more details.
Target branches: master, 3.5, 3.4.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2672
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 543d427ec04db6475b47458890cfe12e9cd6cb15
Author: Michael Han <ha...@apache.org>
Date: 2017-01-23T18:32:01Z
ZOOKEEPER-2672: Remove CHANGE.txt.
The CHANGE.txt is already not the source of truth of what's changed after we migrating to git - most of the git commits in recent couple of months don't update CHANGE.txt. The option of updating CHANGE.txt during commit flow automatically is none trivial, and do that manually is cumbersome and error prone.
The consensus is we would rely on source control revision logs instead of CHANGE.txt moving forward; see https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for more details.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #154: ZOOKEEPER-2672: Remove CHANGE.txt.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---