You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2017/01/17 11:22:36 UTC
Review Request 55611: Paused the status update manager in
`Slave::initialize()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55611/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
This is done so that any updates that the status update manager
receives while the agent is in recovery (e.g., executor terminated)
are not un-necessarily forwarded to and dropped by the agent.
Diffs
-----
src/slave/slave.cpp ae183e6b8b40094b4764525a6d63164f210ef9d8
Diff: https://reviews.apache.org/r/55611/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 55611: Paused the status update manager in
`Slave::initialize()`.
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 18, 2017, 7:49 a.m., Greg Mann wrote:
> > src/slave/slave.cpp, lines 557-560
> > <https://reviews.apache.org/r/55611/diff/1/?file=1606500#file1606500line557>
> >
> > Should we add a test that fails without this patch, i.e. one in which the agent drops a status update which is generated during agent initialization/recovery?
While agent does drop an update generated during recovery without this patch, it will eventually send that update after it registers. So it would be hard to write a test. Let me know if you have concrete ideas.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55611/#review162038
-----------------------------------------------------------
On Jan. 17, 2017, 11:22 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55611/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 11:22 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is done so that any updates that the status update manager
> receives while the agent is in recovery (e.g., executor terminated)
> are not un-necessarily forwarded to and dropped by the agent.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp ae183e6b8b40094b4764525a6d63164f210ef9d8
>
> Diff: https://reviews.apache.org/r/55611/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 55611: Paused the status update manager in
`Slave::initialize()`.
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 18, 2017, 7:49 a.m., Greg Mann wrote:
> > src/slave/slave.cpp, lines 557-560
> > <https://reviews.apache.org/r/55611/diff/1/?file=1606500#file1606500line557>
> >
> > Should we add a test that fails without this patch, i.e. one in which the agent drops a status update which is generated during agent initialization/recovery?
>
> Vinod Kone wrote:
> While agent does drop an update generated during recovery without this patch, it will eventually send that update after it registers. So it would be hard to write a test. Let me know if you have concrete ideas.
I'm commiting this chain to stabilize the CI. Will be happy to write a proper test in a subsequent review once we figure out how to write one.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55611/#review162038
-----------------------------------------------------------
On Jan. 17, 2017, 11:22 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55611/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 11:22 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is done so that any updates that the status update manager
> receives while the agent is in recovery (e.g., executor terminated)
> are not un-necessarily forwarded to and dropped by the agent.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp ae183e6b8b40094b4764525a6d63164f210ef9d8
>
> Diff: https://reviews.apache.org/r/55611/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 55611: Paused the status update manager in
`Slave::initialize()`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55611/#review162038
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.cpp (lines 557 - 560)
<https://reviews.apache.org/r/55611/#comment233293>
Should we add a test that fails without this patch, i.e. one in which the agent drops a status update which is generated during agent initialization/recovery?
- Greg Mann
On Jan. 17, 2017, 11:22 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55611/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 11:22 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is done so that any updates that the status update manager
> receives while the agent is in recovery (e.g., executor terminated)
> are not un-necessarily forwarded to and dropped by the agent.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp ae183e6b8b40094b4764525a6d63164f210ef9d8
>
> Diff: https://reviews.apache.org/r/55611/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>