[GitHub] [spark] wangyum commented on a diff in pull request #38682: [SPARK-41167][SQL] Improve multi like performance by creating a balanced expression tree predicate

[GitBox <gi...@apache.org>]

wangyum commented on code in PR #38682:
URL: https://github.com/apache/spark/pull/38682#discussion_r1039110128


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:
##########
@@ -756,16 +756,16 @@ object LikeSimplification extends Rule[LogicalPlan] {
     } else {
       multi match {
         case l: LikeAll =>
-          val and = replacements.reduceLeft(And)
+          val and = buildBalancedPredicate(replacements, And.apply)

Review Comment:
   buildBalancedPredicate(replacements, And.apply) -> buildBalancedPredicate(replacements, And)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org