You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/10/22 18:59:16 UTC
Re: Review Request 39537: Windows: Moved `os::utime` to its own file,
`stout/os/utime.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39537/#review103599
-----------------------------------------------------------
Ship it!
Confirmed that logic of `utime` did not change.
3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp (lines 17 - 21)
<https://reviews.apache.org/r/39537/#comment161674>
Nit: Can you flip the `#ifndef`? No need to negate the conditional if there's an `#else`.
- Joseph Wu
On Oct. 21, 2015, 8:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39537/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 8:35 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39537/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39537: Windows: Moved `os::utime` to its own file,
`stout/os/utime.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Oct. 22, 2015, 4:59 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp, lines 17-21
> > <https://reviews.apache.org/r/39537/diff/1/?file=1103021#file1103021line17>
> >
> > Nit: Can you flip the `#ifndef`? No need to negate the conditional if there's an `#else`.
Yeah, so as a matter of style, I've tried to keep all the conditionals that apply to Unix to appear first, so that regardless of the conditional, you knew where to look, but I think you might be right that this actually hurts clarity, because it is not obvious.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39537/#review103599
-----------------------------------------------------------
On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39537/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 3:35 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39537/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>