You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/12/23 07:34:45 UTC
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1279
engine/schema: Use semantically correct upgrade path 4.6.2->4.7.0
Adds an explicit upgrade path class from 4.6.2 to 4.7.0, that extends over
the upgrade path from 4.6.1 to 4.7.0
cc @remibergsma @DaanHoogland -- from #1247
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 462to470pathfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1279.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1279
----
commit 6c5a182c39d62c7615ba3c9ebdecc7fffc541d9f
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-12-16T09:01:00Z
engine/schema: Use semantically correct upgrade path 4.6.2->4.7.0
Adds an explicit upgrade path class from 4.6.2 to 4.7.0, that extends over
the upgrade path from 4.6.1 to 4.7.0
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-175504959
Such a waste
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174211155
I've heard everyone's comments on this, I stand by my PR. The argument that DB upgrade works is not relevant to what this PR fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-172369667
I don't see the semantic necessity for this. doe upgrades work different if Upgrade461to470() is used insted of an empty Upgrade462to470()? It is just adding a code duplication.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174196682
For the record: the upgrade works:
```
2016-01-23 16:06:44,796 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) DB version = 4.6.2 Code Version = 4.7.1-SNAPSHOT
2016-01-23 16:06:44,797 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Database upgrade must be performed from 4.6.2 to 4.7.1-SNAPSHOT
2016-01-23 16:06:44,797 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade462to470 to upgrade from 4.6.2-4.7.0 to 4.7.0
2016-01-23 16:06:44,800 DEBUG [c.c.u.s.Script] (main:null) (logid:) Looking for db/schema-461to470.sql in the classpath
```
And then:
```
2016-01-23 16:06:44,803 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Schema upgrade from 4.6.1 to 4.7.0;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174326800
Ok let me rephrase as well: this is extra code without extra functionality: :-1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-169133536
Didn't have a chance to test it yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174211604
@bhaisaab Let me rephrase: I tested your PR and that works :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-168902444
Ping @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-169133233
Did the tests succeed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-166883594
@bhaisaab Thanks, makes sense. Will test an upgrade and report back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---