[openoffice] 01/05: Fix a classic bug that was breaking all registry modifications during tests, where the return value of a string change method was not getting assigned anywhere, and the original read-only string was expected to be the one changed.

[ms...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mseidel pushed a commit to branch AOO42X
in repository https://gitbox.apache.org/repos/asf/openoffice.git

commit 2ee5ff7e23efb40012a048bb1281f532d48e08a8
Author: Damjan Jovanovic <da...@apache.org>
AuthorDate: Fri Jul 31 04:41:31 2020 +0200

    Fix a classic bug that was breaking all registry modifications during tests,
    where the return value of a string change method was not getting assigned
    anywhere, and the original read-only string was expected to be the
    one changed.
    
    Patch by: me
    
    (cherry picked from commit 5045dcc653b31c87d6b268d887ec5821c03a2dec)
---
 test/testcommon/source/org/openoffice/test/OpenOffice.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/testcommon/source/org/openoffice/test/OpenOffice.java b/test/testcommon/source/org/openoffice/test/OpenOffice.java
index 0a549b0..a5de6d5 100644
--- a/test/testcommon/source/org/openoffice/test/OpenOffice.java
+++ b/test/testcommon/source/org/openoffice/test/OpenOffice.java
@@ -332,7 +332,7 @@ public class OpenOffice {
 					newContent += item;
 				}
 			}
-			content.replace("</oor:items>", "");
+			content = content.replace("</oor:items>", "");
 			if (content.length() == 0)
 				content += "<?xml version=\"1.0\" encoding=\"UTF-8\"?><oor:items xmlns:oor=\"http://openoffice.org/2001/registry\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\">";
 			content += newContent + "</oor:items>";