You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/11/07 12:42:31 UTC

[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #341: omega-edit updates

stevedlawrence commented on code in PR #341:
URL: https://github.com/apache/daffodil-vscode/pull/341#discussion_r1015373551


##########
build/package/NOTICE:
##########
@@ -280,3 +280,18 @@ The following NOTICE information applies to binary components distributed with t
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
+
+- 'omega-edit' in extension/dist/ext/extension.js
+  Copyright 2021 Concurrent Technologies Corporation.
+
+  Licensed under the Apache License, Version 2.0 (the "License");

Review Comment:
   This is correct since this is what's in omega-edit's NOTICE file, but in case omega-edit devs see this, the ASF recommends to not put the license in the NOTICE file (that's what the LICENSE is for). This file usually about copyright information, code origins, and third-party NOTICES.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org