You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/18 07:20:16 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request, #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) override template details
Pearl1594 opened a new pull request, #6276:
URL: https://github.com/apache/cloudstack/pull/6276
### Description
This PR allows VM details wrt root & data disk controller passed via details parameter of deployVMCmd to take precedence over template settings, i.e., the order of precedence for determining VM disk controller is : VM details passed during deployment > template settings > global setting `vmware.root.disk.controller` .
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219239407
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1204976447
@DaanHoogland unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1178282544
<b>Trillian test result (tid-4445)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42395 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4445-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 805.25 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219240157
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6276)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6276&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6276&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6276&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6276&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6276&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6276&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6276&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6276&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1178397881
<b>Trillian test result (tid-4446)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50385 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4446-vmware-65u2.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 8.00 | test_deploy_vm_iso.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101194756
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101616756
<b>Trillian test result (tid-3926)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30821 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t3926-kvm-centos7.zip
Smoke tests completed. 93 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1106062207
@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1220873412
<b>Trillian test result (tid-4739)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40362 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4739-vmware-65u2.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1220888541
<b>Trillian test result (tid-4738)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41359 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4738-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1204975623
@blueorangutan test centos7 vmaware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1206286079
> Test Result Time (s) Test File
> test_deploy_vm_from_iso `Error` 7.84 test_deploy_vm_iso.py
@Pearl1594 , this remaining error seems to be consistent. Can you look at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) override template details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101175062
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101175338
@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1106098684
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1204488523
<b>Trillian test result (tid-4608)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37818 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4608-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1178268121
<b>Trillian test result (tid-4444)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41636 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4444-xenserver-71.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 1037.06 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1193712649
@Pearl1594 can you address Guto's review comment. Other than that PR looks all good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219197679
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1178794443
@Pearl1594 will you apply @GutoVeronezi's suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205908067
<b>Trillian test result (tid-4621)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39638 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4621-vmware-70u3.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 7.84 | test_deploy_vm_iso.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101672215
<b>Trillian test result (tid-3925)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34828 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t3925-xenserver-71.zip
Smoke tests completed. 91 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestListIdsParams>:teardown | `Error` | 1.15 | test_list_ids_parameter.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1990.88 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1990.94 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1189922438
@Pearl1594 This also needs base branch change to 4.17, I see this is targetted to 4.17.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1170825592
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1177286451
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1203758168
@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1203757239
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1177337968
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205223857
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1220251791
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1220251446
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr merged pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1106061911
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1109396467
Is this essential for 4.17 @nvazquez @Pearl1594 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1190019573
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1190018487
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1191077222
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
rohityadavcloud closed pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
URL: https://github.com/apache/cloudstack/pull/6276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205011075
@blueorangutan test centos7 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1106059561
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 3269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205019300
<b>Trillian Build Failed (tid-4620)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1220834486
<b>Trillian test result (tid-4737)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38043 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4737-xenserver-71.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 623.84 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1191077906
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1103408310
@Pearl1594 is this ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1109432385
@rohityadavcloud this isn't essential for 4.17.0 as this has always been the behavior and there also exists a workaround, where users can change the template setting for root disk controller. So IMO this can go into 4.17.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219197213
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219237279
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219238302
@blueorangutan test centos7 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on code in PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#discussion_r934409626
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -4442,6 +4421,42 @@ public UserVmVO doInTransaction(TransactionStatus status) throws InsufficientCap
});
}
+ private void updateVMDiskController(UserVmVO vm, Map<String, String> customParameters, GuestOSVO guestOS) {
+ // If hypervisor is vSphere and OS is OS X, set special settings.
+ if (guestOS.getDisplayName().toLowerCase().contains("apple mac os")) {
+ vm.setDetail(VmDetailConstants.SMC_PRESENT, "TRUE");
+ vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, "scsi");
+ vm.setDetail(VmDetailConstants.DATA_DISK_CONTROLLER, "scsi");
+ vm.setDetail(VmDetailConstants.FIRMWARE, "efi");
+ s_logger.info("guestOS is OSX : overwrite root disk controller to scsi, use smc and efi");
+ } else {
+ String rootDiskControllerSetting = customParameters.get(VmDetailConstants.ROOT_DISK_CONTROLLER);
+ String dataDiskControllerSetting = customParameters.get(VmDetailConstants.DATA_DISK_CONTROLLER);
+ if (StringUtils.isNotEmpty(rootDiskControllerSetting)) {
+ vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, rootDiskControllerSetting);
+ }
+
+ if (StringUtils.isNotEmpty(dataDiskControllerSetting)) {
+ vm.setDetail(VmDetailConstants.DATA_DISK_CONTROLLER, dataDiskControllerSetting);
+ }
+
+ String controllerSetting = StringUtils.defaultIfEmpty(_configDao.getValue(Config.VmwareRootDiskControllerType.key()),
+ Config.VmwareRootDiskControllerType.getDefaultValue());
+
+ // Don't override if VM already has root/data disk controller detail
+ if (vm.getDetail(VmDetailConstants.ROOT_DISK_CONTROLLER) == null) {
+ vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, controllerSetting);
+ }
Review Comment:
I am not sure if it's worth doing this at this point, as it's not merely checking if it's null and setting it to some value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1202160024
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1204455667
<b>Trillian test result (tid-4607)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35742 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4607-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101245191
@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) override template details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101244903
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#discussion_r853905419
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -4442,6 +4421,42 @@ public UserVmVO doInTransaction(TransactionStatus status) throws InsufficientCap
});
}
+ private void updateVMDiskController(UserVmVO vm, Map<String, String> customParameters, GuestOSVO guestOS) {
+ // If hypervisor is vSphere and OS is OS X, set special settings.
+ if (guestOS.getDisplayName().toLowerCase().contains("apple mac os")) {
+ vm.setDetail(VmDetailConstants.SMC_PRESENT, "TRUE");
+ vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, "scsi");
+ vm.setDetail(VmDetailConstants.DATA_DISK_CONTROLLER, "scsi");
+ vm.setDetail(VmDetailConstants.FIRMWARE, "efi");
+ s_logger.info("guestOS is OSX : overwrite root disk controller to scsi, use smc and efi");
+ } else {
+ String rootDiskControllerSetting = customParameters.get(VmDetailConstants.ROOT_DISK_CONTROLLER);
Review Comment:
code lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#discussion_r856615102
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -4442,6 +4421,42 @@ public UserVmVO doInTransaction(TransactionStatus status) throws InsufficientCap
});
}
+ private void updateVMDiskController(UserVmVO vm, Map<String, String> customParameters, GuestOSVO guestOS) {
+ // If hypervisor is vSphere and OS is OS X, set special settings.
+ if (guestOS.getDisplayName().toLowerCase().contains("apple mac os")) {
+ vm.setDetail(VmDetailConstants.SMC_PRESENT, "TRUE");
+ vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, "scsi");
+ vm.setDetail(VmDetailConstants.DATA_DISK_CONTROLLER, "scsi");
+ vm.setDetail(VmDetailConstants.FIRMWARE, "efi");
+ s_logger.info("guestOS is OSX : overwrite root disk controller to scsi, use smc and efi");
+ } else {
+ String rootDiskControllerSetting = customParameters.get(VmDetailConstants.ROOT_DISK_CONTROLLER);
+ String dataDiskControllerSetting = customParameters.get(VmDetailConstants.DATA_DISK_CONTROLLER);
+ if (StringUtils.isNotEmpty(rootDiskControllerSetting)) {
+ vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, rootDiskControllerSetting);
+ }
+
+ if (StringUtils.isNotEmpty(dataDiskControllerSetting)) {
+ vm.setDetail(VmDetailConstants.DATA_DISK_CONTROLLER, dataDiskControllerSetting);
+ }
+
+ String controllerSetting = StringUtils.defaultIfEmpty(_configDao.getValue(Config.VmwareRootDiskControllerType.key()),
+ Config.VmwareRootDiskControllerType.getDefaultValue());
+
+ // Don't override if VM already has root/data disk controller detail
+ if (vm.getDetail(VmDetailConstants.ROOT_DISK_CONTROLLER) == null) {
+ vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, controllerSetting);
+ }
Review Comment:
In UserVmVO we could create a method like `setDetailIfNull`. This way we can centralize the validation and reduce a bit of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1106032407
@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1177342436
@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1202102940
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1202102563
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205011387
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1190035837
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1101659210
<b>Trillian test result (tid-3927)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33915 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t3927-vmware-65u2.zip
Smoke tests completed. 92 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_from_iso | `Error` | 7.77 | test_deploy_vm_iso.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1106031848
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1191118038
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1170826282
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1171079458
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205223291
@blueorangutan test centos7 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1204501085
<b>Trillian test result (tid-4609)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38920 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4609-vmware-65u2.zip
Smoke tests completed. 97 look OK, 4 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup | `Error` | 42.56 | test_affinity_groups.py
test_DeployVmAntiAffinityGroup_in_project | `Error` | 95.86 | test_affinity_groups_projects.py
test_deploy_vm_from_iso | `Error` | 7.81 | test_deploy_vm_iso.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 40.99 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1177285334
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1177341499
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219333580
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6276](https://codecov.io/gh/apache/cloudstack/pull/6276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59c5d0f) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/010b47f82eb451c64be9b837b6bef30867b1ff58?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (010b47f) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #6276 +/- ##
=========================================
Coverage 5.86% 5.86%
- Complexity 3918 3920 +2
=========================================
Files 2451 2451
Lines 242268 242277 +9
Branches 37910 37912 +2
=========================================
+ Hits 14207 14211 +4
- Misses 226491 226496 +5
Partials 1570 1570
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1219949305
<b>Trillian test result (tid-4725)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40107 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4725-vmware-70u3.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org