You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/03 18:58:19 UTC
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18696
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
KUDU-2671 fix handling ranges with table-wide hash schemas
This patch fixes a bug/typo introduced recently: adding a range with
the table-wide hash schema would be a no-op when
--enable_per_range_hash_schemas was set 'true'.
I added new test scenarios to cover the regression and verified
that, as expected, they would fail without the fix.
This is a follow-up to f55dd22bfea4beee99d72891efbbc67307b19d1e.
Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
---
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
3 files changed, 302 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18696/1
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18696 )
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18696/2/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/18696/2/src/kudu/master/master-test.cc@1374
PS2, Line 1374: //ASSERT_EQ(5, hash_schema.seed());
nit: uncomment this.
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sun, 10 Jul 2022 23:51:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18696 )
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
Patch Set 2: Verified+1
unrelated test failures:
* RaftConsensusITest.TestSlowFollower (RELEASE)
* log_rolling-itest (ASAN)
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 18:19:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kurt Deschler, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18696
to look at the new patch set (#2).
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
KUDU-2671 fix handling ranges with table-wide hash schemas
This patch fixes a bug/typo introduced recently: adding a range with
the table-wide hash schema would be a no-op when
--enable_per_range_hash_schemas was set 'true'.
I added new test scenarios to cover the regression and verified
that, as expected, they would fail without the fix.
This is a follow-up to f55dd22bfea4beee99d72891efbbc67307b19d1e.
Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
---
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
3 files changed, 299 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18696/2
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18696 )
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
KUDU-2671 fix handling ranges with table-wide hash schemas
This patch fixes a bug/typo introduced recently: adding a range with
the table-wide hash schema would be a no-op when
--enable_per_range_hash_schemas was set 'true'.
I added new test scenarios to cover the regression and verified
that, as expected, they would fail without the fix.
This is a follow-up to f55dd22bfea4beee99d72891efbbc67307b19d1e.
Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Reviewed-on: http://gerrit.cloudera.org:8080/18696
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
3 files changed, 299 insertions(+), 31 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18696 )
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jul 2022 16:22:43 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18696 )
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jul 2022 21:51:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 fix handling ranges with table-wide hash schemas
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18696 )
Change subject: KUDU-2671 fix handling ranges with table-wide hash schemas
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18696/2/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/18696/2/src/kudu/master/master-test.cc@1374
PS2, Line 1374: //ASSERT_EQ(5, hash_schema.seed());
> nit: uncomment this.
I'm going to address this in a separate changelist. It seems the seed-related info isn't checked anywhere, and I'm planning to take care of that in other test scenarios as well.
--
To view, visit http://gerrit.cloudera.org:8080/18696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I908e9654ed856920d483ce63a546946cbac0a641
Gerrit-Change-Number: 18696
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jul 2022 23:02:07 +0000
Gerrit-HasComments: Yes