You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Oliver Wulff (JIRA)" <ji...@apache.org> on 2011/06/07 23:08:58 UTC
[jira] [Created] (CXF-3576) Potential overflow for lifetime
calculation in STSClient
Potential overflow for lifetime calculation in STSClient
--------------------------------------------------------
Key: CXF-3576
URL: https://issues.apache.org/jira/browse/CXF-3576
Project: CXF
Issue Type: Bug
Components: WS-* Components
Affects Versions: 2.4
Reporter: Oliver Wulff
Fix For: 2.4.1
This code performs integer multiply and then converts the result to a long:
expirationTime.setTime(creationTime.getTime() + (ttl * 1000));
Fix:
expirationTime.setTime(creationTime.getTime() + (ttl * 1000L));
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-3576) Potential overflow for lifetime
calculation in STSClient
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045788#comment-13045788 ]
Christian Schneider commented on CXF-3576:
------------------------------------------
Hi Oli. This is no ordinary patch file. How do I apply this?
> Potential overflow for lifetime calculation in STSClient
> --------------------------------------------------------
>
> Key: CXF-3576
> URL: https://issues.apache.org/jira/browse/CXF-3576
> Project: CXF
> Issue Type: Bug
> Components: WS-* Components
> Affects Versions: 2.4
> Reporter: Oliver Wulff
> Fix For: 2.4.1
>
> Attachments: patch.diff
>
>
> This code performs integer multiply and then converts the result to a long:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000));
> Fix:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000L));
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-3576) Potential overflow for lifetime
calculation in STSClient
Posted by "Oliver Wulff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Wulff updated CXF-3576:
------------------------------
Attachment: STSClient.patch
I've updated the patch and attached again.
I used the following tool to create the patch:
diff -crB <old> <new>
> Potential overflow for lifetime calculation in STSClient
> --------------------------------------------------------
>
> Key: CXF-3576
> URL: https://issues.apache.org/jira/browse/CXF-3576
> Project: CXF
> Issue Type: Bug
> Components: WS-* Components
> Affects Versions: 2.4
> Reporter: Oliver Wulff
> Fix For: 2.4.1
>
> Attachments: STSClient.patch, patch.diff
>
>
> This code performs integer multiply and then converts the result to a long:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000));
> Fix:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000L));
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CXF-3576) Potential overflow for lifetime
calculation in STSClient
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider reassigned CXF-3576:
----------------------------------------
Assignee: Christian Schneider
> Potential overflow for lifetime calculation in STSClient
> --------------------------------------------------------
>
> Key: CXF-3576
> URL: https://issues.apache.org/jira/browse/CXF-3576
> Project: CXF
> Issue Type: Bug
> Components: WS-* Components
> Affects Versions: 2.4
> Reporter: Oliver Wulff
> Assignee: Christian Schneider
> Fix For: 2.4.1
>
> Attachments: STSClient.patch, patch.diff
>
>
> This code performs integer multiply and then converts the result to a long:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000));
> Fix:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000L));
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CXF-3576) Potential overflow for lifetime
calculation in STSClient
Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider resolved CXF-3576.
--------------------------------------
Resolution: Fixed
Patch applied Jenkins tests currently running
> Potential overflow for lifetime calculation in STSClient
> --------------------------------------------------------
>
> Key: CXF-3576
> URL: https://issues.apache.org/jira/browse/CXF-3576
> Project: CXF
> Issue Type: Bug
> Components: WS-* Components
> Affects Versions: 2.4
> Reporter: Oliver Wulff
> Assignee: Christian Schneider
> Fix For: 2.4.1
>
> Attachments: STSClient.patch, patch.diff
>
>
> This code performs integer multiply and then converts the result to a long:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000));
> Fix:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000L));
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-3576) Potential overflow for lifetime
calculation in STSClient
Posted by "Oliver Wulff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Wulff updated CXF-3576:
------------------------------
Attachment: patch.diff
diff of patch attached
> Potential overflow for lifetime calculation in STSClient
> --------------------------------------------------------
>
> Key: CXF-3576
> URL: https://issues.apache.org/jira/browse/CXF-3576
> Project: CXF
> Issue Type: Bug
> Components: WS-* Components
> Affects Versions: 2.4
> Reporter: Oliver Wulff
> Fix For: 2.4.1
>
> Attachments: patch.diff
>
>
> This code performs integer multiply and then converts the result to a long:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000));
> Fix:
> expirationTime.setTime(creationTime.getTime() + (ttl * 1000L));
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira