You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/29 15:03:40 UTC

[GitHub] [zookeeper] kezhuw opened a new pull request, #1901: ZOOKEEPER-4308: Fix flaky test EagerACLFilterTest

kezhuw opened a new pull request, #1901:
URL: https://github.com/apache/zookeeper/pull/1901

   There are several problems in this test:
   * It uses `ParameterizedTest` which run tests in single jvm. But
     `ZooKeeperServer.enableEagerACLCheck` is `static` and loaded from env
     variable.
   * It uses `assertNotSame` which assert on object reference equiality.
   * It asserts on `zkLeader.getLastLoggedZxid()` while client connect to
     `connectedServer`. There is no happen-before between
     `zkLeader.getLastLoggedZxid()` and successful response from other
     server. The commit and response are routed to different servers and
     performed asynchronous in each server.
   
   Author: Kezhu Wang <ke...@gmail.com>
   
   Reviewers: maoling <ma...@sina.com>, Mate Szalay-Beko <sy...@apache.org>
   
   Closes #1851 from kezhuw/ZOOKEEPER-4308-EagerACLFilterTest
   
   (cherry picked from commit 794790c9f6cbacf158493867f3058a6de748b54e)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] maoling commented on pull request #1901: ZOOKEEPER-4308: Fix flaky test EagerACLFilterTest

Posted by GitBox <gi...@apache.org>.

maoling commented on PR #1901:
URL: https://github.com/apache/zookeeper/pull/1901#issuecomment-1236292021

   @kezhuw 
   Thanks for your contribution. Now we have this fix at all branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] maoling closed pull request #1901: ZOOKEEPER-4308: Fix flaky test EagerACLFilterTest

Posted by GitBox <gi...@apache.org>.

maoling closed pull request #1901: ZOOKEEPER-4308: Fix flaky test EagerACLFilterTest
URL: https://github.com/apache/zookeeper/pull/1901


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw commented on pull request #1901: ZOOKEEPER-4308: Fix flaky test EagerACLFilterTest

Posted by GitBox <gi...@apache.org>.

kezhuw commented on PR #1901:
URL: https://github.com/apache/zookeeper/pull/1901#issuecomment-1170098105

   @maoling @symat This is backport of #1851 to branch 3.6. Automatic cherry-pick fails due to junit changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org