You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/23 00:46:42 UTC
[PR] docs(meta-db): warn that SUPERSET_META_DB_LIMIT truncates tables before joins [superset]
rusackas opened a new pull request, #41302:
URL: https://github.com/apache/superset/pull/41302
### SUMMARY
Addresses #36304. When the Superset meta database (`ENABLE_SUPERSET_META_DB`) joins across underlying databases, `SUPERSET_META_DB_LIMIT` (default 1000) is applied to each underlying table *before* the in-memory join runs, not to the final result. If any joined table has more rows than the limit, only the first `SUPERSET_META_DB_LIMIT` rows of that table are read, so matching rows can be silently dropped and the join can return incomplete or empty results with no error. The existing docs mention the per-table limit but don't warn that it can silently produce wrong results. This adds a `:::warning` admonition next to the existing `SUPERSET_META_DB_LIMIT` prose explaining the behavior and the workaround (raise the limit above your largest joined table, or set it to `None` for small tables). Docs-only; the underlying behavior is left for a separate fix decision, so the issue stays open.
### TESTING INSTRUCTIONS
Docs only. No code changes.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #36304
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(meta-db): warn that SUPERSET_META_DB_LIMIT truncates tables before joins [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #41302:
URL: https://github.com/apache/superset/pull/41302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(meta-db): warn that SUPERSET_META_DB_LIMIT truncates tables before joins [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41302:
URL: https://github.com/apache/superset/pull/41302#issuecomment-4774492111
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(meta-db): warn that SUPERSET_META_DB_LIMIT truncates tables before joins [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41302:
URL: https://github.com/apache/superset/pull/41302#issuecomment-4774499221
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2c63a838299e9a06b3f53f2b74d99e3cc4249e1b |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a39d772a3f3310008006398 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41302--superset-docs-preview.netlify.app](https://deploy-preview-41302--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5aWuhrB_0jNU1MjSlJIjo73mbw7yQzxRzgRmgAXPyYbdqSfZqoyusxKg9-UMFH31Rlm_HpU5xOaRnkXoHpknGsWdaiTpE1IgDTRq-Hw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-41302--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org