You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/01/04 08:32:37 UTC
[GitHub] zeppelin pull request #1837: ZEPPELIN-1901. Output schema might be null for ...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/1837
ZEPPELIN-1901. Output schema might be null for PigQueryInterpreter
### What is this PR for?
The output schema might be null if user doesn't specify it explicitly. In this PR, I will use 'col_{pos}' to replace the column name if it is null.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1901
### How should this be tested?
Unit test is added.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1837
----
commit a42615644710b7189d690c85d1aa09f773a76b11
Author: Jeff Zhang <zj...@apache.org>
Date: 2017-01-04T08:29:50Z
ZEPPELIN-1901. Output schema might be null for PigQueryInterpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1837: ZEPPELIN-1901. Output schema might be null for PigQuer...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1837
Ping @felixcheung , CI failure is not relevant.
```
AngularElem
- should provide onclick method *** FAILED ***
The code passed to eventually never returned normally. Attempted 1 times over 192.484891 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:64)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1837: ZEPPELIN-1901. Output schema might be null for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1837: ZEPPELIN-1901. Output schema might be null for PigQuer...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1837
LGTM
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1837: ZEPPELIN-1901. Output schema might be null for PigQuer...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1837
@felixcheung Please help review, I will add document in #1830 to encourage user to specify schema explictly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1837: ZEPPELIN-1901. Output schema might be null for ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/1837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1837: ZEPPELIN-1901. Output schema might be null for ...
Posted by zjffdu <gi...@git.apache.org>.
GitHub user zjffdu reopened a pull request:
https://github.com/apache/zeppelin/pull/1837
ZEPPELIN-1901. Output schema might be null for PigQueryInterpreter
### What is this PR for?
The output schema might be null if user doesn't specify it explicitly. In this PR, I will use 'col_{pos}' to replace the column name if it is null.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1901
### How should this be tested?
Unit test is added.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1837
----
commit a42615644710b7189d690c85d1aa09f773a76b11
Author: Jeff Zhang <zj...@apache.org>
Date: 2017-01-04T08:29:50Z
ZEPPELIN-1901. Output schema might be null for PigQueryInterpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---