You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2017/12/18 18:01:01 UTC
[GitHub] nifi-minifi pull request #107: MINIFI-420 Migrate Windows service executable...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/107
MINIFI-420 Migrate Windows service executable handling to minifi-assembly
MINIFI-420 Migrate Windows service executable handling to minifi-assembly to avoid executables in source packages.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
- [-] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi MINIFI-420
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 0603a93b9142da75f930e517d41db0fad1b3a513
Author: Aldrin Piri <al...@apache.org>
Date: 2017-12-18T17:49:38Z
MINIFI-420 Migrate Windows service executable handling to minifi-assembly to avoid executables in source packages.
----
---
[GitHub] nifi-minifi pull request #107: MINIFI-420 Migrate Windows service executable...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi/pull/107
---