[GitHub] httpclient issue #74: WIP: OpenTracing integration

[adriancole <gi...@git.apache.org>]

Github user adriancole commented on the issue:

    https://github.com/apache/httpclient/pull/74
  
    hey, oleg. different project but same problem.
    
    Here's an example of instrumenting the async client w/ v4.3
     (apologies I made no useful code comments explaining..)
    https://github.com/openzipkin/brave/blob/master/instrumentation/httpasyncclient/src/main/java/brave/httpasyncclient/TracingHttpAsyncClientBuilder.java
    
    The main concerns are split into a several areas:
    * how to propagate state internally throughout the request (ex stuffing
    things in attributes)
    * how to make state visible to user interceptors (ex thread scoping)
    * how to ensure span lifecycle happens (callbacks)
    * what to add to the span (parsing)
    
    You can do everything except the "user interceptors" part and tracing will
    work fine. It is just that some users want to do things like add to a trace
    manually. That's what's lost when you don't have clean hooks into executors
    or other means to start work.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org