You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/03/21 21:27:58 UTC

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9743


Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................

IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Switches the default from MINICLUSTER_PROFILE=2 to
MINICLUSTER_PROFILE=3.

This change is separate from the preceding change which does
all the heavy lifting, just for convenience.

Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/9743/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................

IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Switches the default from MINICLUSTER_PROFILE=2 to
MINICLUSTER_PROFILE=3.

This change is separate from the preceding change which does
all the heavy lifting, just for convenience.

Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/9743/4
-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 9: Code-Review+2

Carry +2 from Alex; this is a rebase with a commit message change.


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 9
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:37:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2190/


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 9
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:37:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 9
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 03:30:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2187/


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:54:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 8:

> I was surprised this commit is missing the "not for 2.x" directive. Was that intentional? Thanks.

No. Unfortunately, the previous one does too. I'll update the commit message here and the ignore lists as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:35:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2187/


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 20:04:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................

IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Switches the default from MINICLUSTER_PROFILE=2 to
MINICLUSTER_PROFILE=3.

This change is separate from the preceding change which does
all the heavy lifting, just for convenience.

Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/9743/8
-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 8:

I was surprised this commit is missing the "not for 2.x" directive. Was that intentional? Thanks.


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:32:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown, Tim Armstrong, Alex Behm, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9743

to look at the new patch set (#9).

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................

IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Switches the default from MINICLUSTER_PROFILE=2 to
MINICLUSTER_PROFILE=3.

This change is separate from the preceding change which does
all the heavy lifting, just for convenience.

Cherry-picks: not for 2.x

Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/9743/9
-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 9
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................


Patch Set 8:

Tested in https://jenkins.impala.io/job/gerrit-verify-dryrun-external/101/


-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 16:07:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9743 )

Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default.
......................................................................

IMPALA-4277: Switch to using Hadoop 3 and friends by default.

Switches the default from MINICLUSTER_PROFILE=2 to
MINICLUSTER_PROFILE=3.

This change is separate from the preceding change which does
all the heavy lifting, just for convenience.

Cherry-picks: not for 2.x

Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Reviewed-on: http://gerrit.cloudera.org:8080/9743
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I424657abebe1c4d6c360b81dab42c2f7b54f8a3e
Gerrit-Change-Number: 9743
Gerrit-PatchSet: 10
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>