You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2015/07/16 06:46:24 UTC
Review Request 36535: SENTRY-805: Reclassify CoreAdminHandler Actions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36535/
-----------------------------------------------------------
Review request for sentry and Vamsee Yarlagadda.
Repository: sentry
Description
-------
I went over the latest CoreAdminHandler code in Solr 4.10 and foudn some minor discrepancies in what we are doing. Biggest one is that REQUESTATUS is classified as an UPDATE request instead of a QUERY request.
Diffs
-----
sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCoreAdminHandler.java c1bde310e46e9dac7fa7814080e9b36c0d1dcd28
sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/handler/admin/SecureCoreAdminHandlerTest.java 1857feb6622f72463f5c465698935b540116fa36
Diff: https://reviews.apache.org/r/36535/diff/
Testing
-------
Ran the solr-sentry unit tests.
Thanks,
Gregory Chanan
Re: Review Request 36535: SENTRY-805: Reclassify CoreAdminHandler
Actions
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36535/#review92140
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 16, 2015, 4:46 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36535/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 4:46 a.m.)
>
>
> Review request for sentry and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> I went over the latest CoreAdminHandler code in Solr 4.10 and foudn some minor discrepancies in what we are doing. Biggest one is that REQUESTATUS is classified as an UPDATE request instead of a QUERY request.
>
>
> Diffs
> -----
>
> sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCoreAdminHandler.java c1bde310e46e9dac7fa7814080e9b36c0d1dcd28
> sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/handler/admin/SecureCoreAdminHandlerTest.java 1857feb6622f72463f5c465698935b540116fa36
>
> Diff: https://reviews.apache.org/r/36535/diff/
>
>
> Testing
> -------
>
> Ran the solr-sentry unit tests.
>
>
> Thanks,
>
> Gregory Chanan
>
>