You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "yunyad (via GitHub)" <gi...@apache.org> on 2025/09/30 04:41:06 UTC

[PR] feat(gui): display the owner's avatar next to each CU [texera]

yunyad opened a new pull request, #3784:
URL: https://github.com/apache/texera/pull/3784

   ### PR Description
   
   This PR implements feature request #3578: displaying the owner's avatar next to each CU (Compute Unit).
   
   - Adds support for fetching and rendering the CU owner's avatar
   - Avatar is typically shown using a small inline image next to the CU label
   
   This change improves UI clarity and helps users quickly identify ownership in collaborative workflows.
   
   Fix #3578 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(gui): display the owner's avatar next to each CU [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #3784:
URL: https://github.com/apache/texera/pull/3784#issuecomment-3350056270

   > @mengw15 Please review it. After that, @aglinxinyuan can review it.
   
   This is still a draft I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(gui): display the owner's avatar next to each CU [texera]

Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #3784:
URL: https://github.com/apache/texera/pull/3784#issuecomment-3350053350

   @mengw15 Please review it.  After that, @aglinxinyuan can review it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(gui): display the owner's avatar next to each CU [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #3784:
URL: https://github.com/apache/texera/pull/3784#issuecomment-3358506936

   @mengw15 please review this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(gui): display the owner's avatar next to each CU [texera]

Posted by "yunyad (via GitHub)" <gi...@apache.org>.
yunyad merged PR #3784:
URL: https://github.com/apache/texera/pull/3784


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(gui): display the owner's avatar next to each CU [texera]

Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on code in PR #3784:
URL: https://github.com/apache/texera/pull/3784#discussion_r2396442499


##########
core/computing-unit-managing-service/src/main/scala/edu/uci/ics/texera/service/resource/ComputingUnitManagingResource.scala:
##########
@@ -551,6 +577,12 @@ class ComputingUnitManagingResource {
   ): DashboardWorkflowComputingUnit = {
 
     val unit = getComputingUnitByCuid(context, cuid)
+    val userDao = new UserDao(context.configuration())
+    val ownerUser = Option(userDao.fetchOneByUid(user.getUid))

Review Comment:
   is here correct to use user? since user here user is the SessionUser?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(gui): display the owner's avatar next to each CU [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #3784:
URL: https://github.com/apache/texera/pull/3784#issuecomment-3353753909

   The current version of Ng-zorro has a bug that the avatar text doesn't center inside the dropdown.
   Added the following line to fix the bug:
   `.ant-avatar-string { position:relative;left:0; }`
   
   | Before | After |
   | ------------- | ------------- |
   | <img width="209" height="47" alt="Screenshot 2025-09-30 at 13 44 10" src="https://github.com/user-attachments/assets/64b04999-b98f-44a5-af5e-fd7fa25d9b7e" />  | <img width="202" height="38" alt="Screenshot 2025-09-30 at 13 46 54" src="https://github.com/user-attachments/assets/b9aba8b9-db60-4b99-a49d-505e62a230f3" /> |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org