[GitHub] [commons-numbers] aherbert commented on a change in pull request #98: Replace assert by simpler but equivalent calls.

[GitBox <gi...@apache.org>]

aherbert commented on a change in pull request #98:
URL: https://github.com/apache/commons-numbers/pull/98#discussion_r664467158



##########
File path: commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
##########
@@ -625,10 +625,10 @@ void testSubtract() {
     @Test
     void testEqualsAndHashCode() {
         final BigFraction zero = BigFraction.of(0, 1);
-        Assertions.assertTrue(zero.equals(zero));
-        Assertions.assertFalse(zero.equals(null));
-        Assertions.assertFalse(zero.equals(new Object()));
-        Assertions.assertFalse(zero.equals(Double.valueOf(0)));
+        Assertions.assertEquals(zero, zero);
+        Assertions.assertNotEquals(null, zero);

Review comment:
       Ping. This once still needs to be reversed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org