[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #6042: [TIR] Add an option to limit the maximum extent of explicitly unrolled loops

[GitBox <gi...@apache.org>]

kevinthesun commented on a change in pull request #6042:
URL: https://github.com/apache/incubator-tvm/pull/6042#discussion_r453809819



##########
File path: src/tir/transforms/unroll_loop.cc
##########
@@ -57,6 +58,9 @@ struct UnrollLoopConfigNode : public tvm::AttrsNode<UnrollLoopConfigNode> {
     TVM_ATTR_FIELD(explicit_unroll)
         .describe("Whether to explicitly unroll the loop instead of setting a pragma")
         .set_default(true);
+    TVM_ATTR_FIELD(explicit_unroll_max_extent)
+        .describe("The maximum extent of a loop that can be unrolled explicitly (-1 for infinite)")
+        .set_default(32);

Review comment:
       It's good to limit unrolling extent. However, would it be better to set default value as -1 so that user can still do arbitrarily unrolling by default and only limit it when necessary? Setting another default value can still potentially cause performance issue for existing tuned schedules.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org