[GitHub] [ignite-3] ygerzhedovich commented on a change in pull request #216: IGNITE-13669: Support temporal types.

[GitBox <gi...@apache.org>]

ygerzhedovich commented on a change in pull request #216:
URL: https://github.com/apache/ignite-3/pull/216#discussion_r674858564



##########
File path: modules/api/src/main/java/org/apache/ignite/schema/ColumnType.java
##########
@@ -116,6 +119,37 @@ public static NumericColumnType number(int precision, int scale) {
         return new NumericColumnType(ColumnTypeSpec.DECIMAL, precision, scale);
     }
 
+    /**
+     * Timezone-free value representing a time of day in hours, minutes, seconds,
+     * and fractional seconds depending on type precision.
+     *
+     * @param precision Fractional seconds part length. Allowed values are 3/6/9 for millis/micros/nanos.

Review comment:
       Why we have such restrictions? For example, Postgresql could use any precision between 0 and 6, in case the user set more than 6 then use 6




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org