You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2023/05/04 08:00:41 UTC

[native-toolchain-CR] Update README about env setup

Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )

Change subject: Update README about env setup
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19750/3/README.md
File README.md:

http://gerrit.cloudera.org:8080/#/c/19750/3/README.md@9
PS3, Line 9: be supported
I think "might also work" would be better because "supported" implies that we take responsibility for it, which is not the case.


http://gerrit.cloudera.org:8080/#/c/19750/3/README.md@21
PS3, Line 21: If you want to build all versions of all packages, you can set the
            : environment variable `BUILD_HISTORICAL=1`. Be warned this will take a
            : long time.
            : 
            :   BUILD_HISTORICAL=1 buildall.sh
The BUILD_HISTORICAL option has been removed by https://gerrit.cloudera.org/#/c/19755/.
Maybe after a rebase it will disappear from here, but let's be careful not to re-introduce it.



-- 
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 08:00:41 +0000
Gerrit-HasComments: Yes