You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/26 11:04:52 UTC

[GitHub] [pulsar] yuruguo commented on a change in pull request #12369: Fix : a simple code optimization

yuruguo commented on a change in pull request #12369:
URL: https://github.com/apache/pulsar/pull/12369#discussion_r736411533



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -527,7 +527,9 @@ private void recoveredCursor(PositionImpl position, Map<String, Long> properties
                 log.info("[{}] [{}] Couldn't find next next valid ledger for recovery {}", ledger.getName(), name,
                         position);
             }
-            position = nextExistingLedger != null ? PositionImpl.get(nextExistingLedger, -1) : position;

Review comment:
       > This modification seems not so necessary.
   
   +1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org