You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by "Adrian Nistor (JIRA)" <ji...@apache.org> on 2013/06/21 20:54:21 UTC

[jira] [Created] (WW-4121) Wasted work in RolesInterceptor.isAllowed()

Adrian Nistor created WW-4121:
---------------------------------

             Summary: Wasted work in RolesInterceptor.isAllowed()
                 Key: WW-4121
                 URL: https://issues.apache.org/jira/browse/WW-4121
             Project: Struts 2
          Issue Type: Bug
          Components: Core Interceptors
    Affects Versions: 2.3.14.3
         Environment: any
            Reporter: Adrian Nistor


The problem appears in version 2.3.14.3 and in revision 1495522.  I
attached a one-line patch that fixes it.  This problem and the
attached patch are similar to the previously fixed WW-4115 and its
patch.

In method "RolesInterceptor.isAllowed", the loop over "allowedRoles"
should break immediately after "result" is set to "true".  All the
iterations after "result" is set to "true" do not perform any useful
work, at best they just set "result" again to "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira