[GitHub] [druid] suneet-s commented on issue #9324: Fix failing Calcite unit tests with existing work-a-round for calcite property setup

[GitBox <gi...@apache.org>]

suneet-s commented on issue #9324: Fix failing Calcite unit tests with existing work-a-round for calcite property setup
URL: https://github.com/apache/druid/pull/9324#issuecomment-583049656
 
 
   @capistrant Thanks for the repro steps. When I wrote the tests, `mvn test` failed locally for a couple classes where it was complaining about something like this 
   
   ```
   org.apache.calcite.sql.validate.SqlValidatorException: Cannot apply <> to the two different charsets UTF-16LE and ISO-8859-1
   ```
   
   but it was in a class I didn't write, and they passed on Travis, so I didn't dig in to why they were failing locally. I wonder if we should be unsetting the system properties that `CalciteTestBase` is setting in every test. That way, we can trust that each test is running in isolation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org