You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/10/22 05:33:02 UTC

[GitHub] [pulsar] Guchman commented on a change in pull request #5429: fix: java doc on MessageListener - acknowledgement part

Guchman commented on a change in pull request #5429: fix: java doc on MessageListener - acknowledgement part
URL: https://github.com/apache/pulsar/pull/5429#discussion_r337335216
 
 

 ##########
 File path: pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/api/MessageListener.java
 ##########
 @@ -33,6 +33,8 @@
      *
      * This method will only be called once for each message, unless either application or broker crashes.
      *
+     * Implementation should acknowledge messages by calling consumer.acknowledge(msg).
 
 Review comment:
   Hm, 1. who will ack messages then? 2. Fair

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services