You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Bernd Vogt (JIRA)" <ji...@codehaus.org> on 2011/08/11 17:57:42 UTC

[jira] Created: (MNG-5153) ModelMerger omits relativ path

ModelMerger omits relativ path
------------------------------

                 Key: MNG-5153
                 URL: https://jira.codehaus.org/browse/MNG-5153
             Project: Maven 2 & 3
          Issue Type: Bug
          Components: General
    Affects Versions: 3.0.3
            Reporter: Bernd Vogt
         Attachments: model-merger-bug.zip

ModelMerger omits relativ path when source is not dominat, because of fiel Parent#relativePath will be initialized with "../pom.xml" on instanciation.

new ModelMerger().merge(target, source, false, null); // merge with sourceDominant = false

Attached test case. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MNG-5153) ModelMerger omits relativ path

Posted by "Bernd Vogt (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MNG-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bernd Vogt reopened MNG-5153:
-----------------------------


Pleas take a look at the unit test.

The target models parent reference is null and the source model contains a fully configured parent object (groupId, artifactId, version and relativPath is set). After merging it with sourceDominant = false the target models parent isn't null any more and its attributes are set with the source models attributes +except the relativPath+. This doesn't makes sense in any case ..

> ModelMerger omits relativ path
> ------------------------------
>
>                 Key: MNG-5153
>                 URL: https://jira.codehaus.org/browse/MNG-5153
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 3.0.3
>            Reporter: Bernd Vogt
>            Assignee: Benjamin Bentmann
>         Attachments: model-merger-bug.zip
>
>
> ModelMerger omits relativ path when source is not dominat, because of fiel Parent#relativePath will be initialized with "../pom.xml" on instanciation.
> new ModelMerger().merge(target, source, false, null); // merge with sourceDominant = false
> Attached test case. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-5153) ModelMerger omits relativ path

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MNG-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-5153.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.4

Oh, got it, fixed in [r1156671|http://svn.apache.org/viewvc?view=revision&revision=1156671].

> ModelMerger omits relativ path
> ------------------------------
>
>                 Key: MNG-5153
>                 URL: https://jira.codehaus.org/browse/MNG-5153
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 3.0.3
>            Reporter: Bernd Vogt
>            Assignee: Benjamin Bentmann
>             Fix For: 3.0.4
>
>         Attachments: model-merger-bug.zip
>
>
> ModelMerger omits relativ path when source is not dominat, because of fiel Parent#relativePath will be initialized with "../pom.xml" on instanciation.
> new ModelMerger().merge(target, source, false, null); // merge with sourceDominant = false
> Attached test case. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-5153) ModelMerger omits relativ path

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MNG-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-5153.
----------------------------------

    Resolution: Not A Bug
      Assignee: Benjamin Bentmann

Keeping the target value is the very purpose of sourceDominant=false.

> ModelMerger omits relativ path
> ------------------------------
>
>                 Key: MNG-5153
>                 URL: https://jira.codehaus.org/browse/MNG-5153
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 3.0.3
>            Reporter: Bernd Vogt
>            Assignee: Benjamin Bentmann
>         Attachments: model-merger-bug.zip
>
>
> ModelMerger omits relativ path when source is not dominat, because of fiel Parent#relativePath will be initialized with "../pom.xml" on instanciation.
> new ModelMerger().merge(target, source, false, null); // merge with sourceDominant = false
> Attached test case. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira