You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/15 09:52:06 UTC
[GitHub] [flink] yanghua opened a new pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
yanghua opened a new pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861
## What is the purpose of the change
*This pull request bumps Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector*
## Brief change log
- *Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector*
- *Update NOTICE FILE*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574591161
<!--
Meta data
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
-->
## CI report:
* f4506ad0e9302a279940670fa90c305c240b3c12 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144485388) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#discussion_r367389539
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -15,31 +15,33 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.httpcomponents:httpasyncclient:4.1.4
- org.apache.httpcomponents:httpclient:4.5.3
- org.apache.httpcomponents:httpcore:4.4.6
-- org.apache.httpcomponents:httpcore-nio:4.4.11
+- org.apache.httpcomponents:httpcore-nio:4.4.12
- org.apache.logging.log4j:log4j-api:2.11.1
- org.apache.logging.log4j:log4j-to-slf4j:2.11.1
-- org.apache.lucene:lucene-analyzers-common:8.1.0
-- org.apache.lucene:lucene-backward-codecs:8.1.0
-- org.apache.lucene:lucene-core:8.1.0
-- org.apache.lucene:lucene-grouping:8.1.0
-- org.apache.lucene:lucene-highlighter:8.1.0
-- org.apache.lucene:lucene-join:8.1.0
-- org.apache.lucene:lucene-memory:8.1.0
-- org.apache.lucene:lucene-misc:8.1.0
-- org.apache.lucene:lucene-queries:8.1.0
-- org.apache.lucene:lucene-queryparser:8.1.0
-- org.apache.lucene:lucene-sandbox:8.1.0
-- org.apache.lucene:lucene-spatial:8.1.0
-- org.apache.lucene:lucene-spatial-extras:8.1.0
-- org.apache.lucene:lucene-spatial3d:8.1.0
-- org.apache.lucene:lucene-suggest:8.1.0
-- org.elasticsearch:elasticsearch:7.3.2
-- org.elasticsearch:elasticsearch-cli:7.3.2
-- org.elasticsearch:elasticsearch-core:7.3.2
-- org.elasticsearch:elasticsearch-secure-sm:7.3.2
-- org.elasticsearch:elasticsearch-x-content:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-client:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.2
-- org.elasticsearch.plugin:aggs-matrix-stats-client:7.3.2
-- org.elasticsearch.plugin:parent-join-client:7.3.2
-- org.elasticsearch.plugin:rank-eval-client:7.3.2
+- org.apache.lucene:lucene-analyzers-common:8.3.0
+- org.apache.lucene:lucene-backward-codecs:8.3.0
+- org.apache.lucene:lucene-core:8.3.0
+- org.apache.lucene:lucene-grouping:8.3.0
+- org.apache.lucene:lucene-highlighter:8.3.0
+- org.apache.lucene:lucene-join:8.3.0
+- org.apache.lucene:lucene-memory:8.3.0
+- org.apache.lucene:lucene-misc:8.3.0
+- org.apache.lucene:lucene-queries:8.3.0
+- org.apache.lucene:lucene-queryparser:8.3.0
+- org.apache.lucene:lucene-sandbox:8.3.0
+- org.apache.lucene:lucene-spatial:8.3.0
+- org.apache.lucene:lucene-spatial-extras:8.3.0
+- org.apache.lucene:lucene-spatial3d:8.3.0
+- org.apache.lucene:lucene-suggest:8.3.0
+- org.elasticsearch:elasticsearch:7.5.1
+- org.elasticsearch:elasticsearch-cli:7.5.1
+- org.elasticsearch:elasticsearch-core:7.5.1
+- org.elasticsearch:elasticsearch-secure-sm:7.5.1
+- org.elasticsearch:elasticsearch-x-content:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-client:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.5.1
+- org.elasticsearch.plugin:aggs-matrix-stats-client:7.5.1
+- org.elasticsearch.plugin:lang-mustache-client:7.5.1
Review comment:
But it's not in the resulting jar. If you run `mvn clean install -DskipTests -Dfast` in the ES7 SQL module you will get some output like this:
```
[INFO] Including org.apache.flink:flink-connector-elasticsearch7_2.11:jar:1.11-SNAPSHOT in the shaded jar.
[INFO] Including org.apache.flink:flink-connector-elasticsearch-base_2.11:jar:1.11-SNAPSHOT in the shaded jar.
[INFO] Including org.elasticsearch.client:elasticsearch-rest-high-level-client:jar:7.5.1 in the shaded jar.
[INFO] Including org.elasticsearch:elasticsearch:jar:7.5.1 in the shaded jar.
[INFO] Including org.elasticsearch:elasticsearch-core:jar:7.5.1 in the shaded jar.
[INFO] Including org.elasticsearch:elasticsearch-secure-sm:jar:7.5.1 in the shaded jar.
[INFO] Including org.elasticsearch:elasticsearch-x-content:jar:7.5.1 in the shaded jar.
[INFO] Excluding org.yaml:snakeyaml:jar:1.17 from the shaded jar.
[INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.10.1 in the shaded jar.
[INFO] Including com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.8.11 in the shaded jar.
[INFO] Including com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.8.11 in the shaded jar.
[INFO] Including com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.8.11 in the shaded jar.
[INFO] Excluding org.elasticsearch:elasticsearch-geo:jar:7.5.1 from the shaded jar.
[INFO] Including org.apache.lucene:lucene-core:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-analyzers-common:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-backward-codecs:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-grouping:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-highlighter:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-join:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-memory:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-misc:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-queries:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-queryparser:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-sandbox:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-spatial:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-spatial-extras:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-spatial3d:jar:8.3.0 in the shaded jar.
[INFO] Including org.apache.lucene:lucene-suggest:jar:8.3.0 in the shaded jar.
[INFO] Including org.elasticsearch:elasticsearch-cli:jar:7.5.1 in the shaded jar.
[INFO] Excluding net.sf.jopt-simple:jopt-simple:jar:5.0.2 from the shaded jar.
[INFO] Excluding com.carrotsearch:hppc:jar:0.8.1 from the shaded jar.
[INFO] Excluding joda-time:joda-time:jar:2.5 from the shaded jar.
[INFO] Excluding com.tdunning:t-digest:jar:3.2 from the shaded jar.
[INFO] Excluding org.hdrhistogram:HdrHistogram:jar:2.1.9 from the shaded jar.
[INFO] Excluding org.elasticsearch:jna:jar:4.5.1 from the shaded jar.
[INFO] Including org.elasticsearch.client:elasticsearch-rest-client:jar:7.5.1 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.3 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.6 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpasyncclient:jar:4.1.4 in the shaded jar.
[INFO] Including org.apache.httpcomponents:httpcore-nio:jar:4.4.12 in the shaded jar.
[INFO] Including commons-codec:commons-codec:jar:1.10 in the shaded jar.
[INFO] Including commons-logging:commons-logging:jar:1.1.3 in the shaded jar.
[INFO] Including org.elasticsearch.plugin:mapper-extras-client:jar:7.5.1 in the shaded jar.
[INFO] Including org.elasticsearch.plugin:parent-join-client:jar:7.5.1 in the shaded jar.
[INFO] Including org.elasticsearch.plugin:aggs-matrix-stats-client:jar:7.5.1 in the shaded jar.
[INFO] Including org.elasticsearch.plugin:rank-eval-client:jar:7.5.1 in the shaded jar.
[INFO] Excluding org.elasticsearch.plugin:lang-mustache-client:jar:7.5.1 from the shaded jar.
[INFO] Excluding com.github.spullara.mustache.java:compiler:jar:0.9.6 from the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-to-slf4j:jar:2.11.1 in the shaded jar.
[INFO] Including org.apache.logging.log4j:log4j-api:jar:2.11.1 in the shaded jar.
[INFO] Including org.apache.flink:force-shading:jar:1.11-SNAPSHOT in the shaded jar.
[INFO] No artifact matching filter io.netty:netty
```
which tells you what is included in the jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on issue #10861: [FLINK-15558][Connector]
Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574997174
Hi @aljoscha Can you please review this PR? I have also updated the NOTICE file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574591161
<!--
Meta data
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:MANUAL TriggerID:574954559
-->
## CI report:
* f4506ad0e9302a279940670fa90c305c240b3c12 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144485388) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574591161
<!--
Meta data
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:MANUAL TriggerID:574954559
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:MANUAL TriggerID:574954559
-->
## CI report:
* f4506ad0e9302a279940670fa90c305c240b3c12 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144485388) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574591161
<!--
Meta data
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:MANUAL TriggerID:574954559
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:MANUAL TriggerID:574954559
-->
## CI report:
* f4506ad0e9302a279940670fa90c305c240b3c12 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144485388) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on issue #10861: [FLINK-15558][Connector]
Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574954527
Relevant test error. rebuild now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on issue #10861: [FLINK-15558][Connector]
Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574954559
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574591161
<!--
Meta data
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
-->
## CI report:
* f4506ad0e9302a279940670fa90c305c240b3c12 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144485388) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574591161
<!--
Meta data
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144485388 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364 TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
-->
## CI report:
* f4506ad0e9302a279940670fa90c305c240b3c12 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144485388) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4364)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on a change in pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#discussion_r367391186
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -15,31 +15,33 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.httpcomponents:httpasyncclient:4.1.4
- org.apache.httpcomponents:httpclient:4.5.3
- org.apache.httpcomponents:httpcore:4.4.6
-- org.apache.httpcomponents:httpcore-nio:4.4.11
+- org.apache.httpcomponents:httpcore-nio:4.4.12
- org.apache.logging.log4j:log4j-api:2.11.1
- org.apache.logging.log4j:log4j-to-slf4j:2.11.1
-- org.apache.lucene:lucene-analyzers-common:8.1.0
-- org.apache.lucene:lucene-backward-codecs:8.1.0
-- org.apache.lucene:lucene-core:8.1.0
-- org.apache.lucene:lucene-grouping:8.1.0
-- org.apache.lucene:lucene-highlighter:8.1.0
-- org.apache.lucene:lucene-join:8.1.0
-- org.apache.lucene:lucene-memory:8.1.0
-- org.apache.lucene:lucene-misc:8.1.0
-- org.apache.lucene:lucene-queries:8.1.0
-- org.apache.lucene:lucene-queryparser:8.1.0
-- org.apache.lucene:lucene-sandbox:8.1.0
-- org.apache.lucene:lucene-spatial:8.1.0
-- org.apache.lucene:lucene-spatial-extras:8.1.0
-- org.apache.lucene:lucene-spatial3d:8.1.0
-- org.apache.lucene:lucene-suggest:8.1.0
-- org.elasticsearch:elasticsearch:7.3.2
-- org.elasticsearch:elasticsearch-cli:7.3.2
-- org.elasticsearch:elasticsearch-core:7.3.2
-- org.elasticsearch:elasticsearch-secure-sm:7.3.2
-- org.elasticsearch:elasticsearch-x-content:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-client:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.2
-- org.elasticsearch.plugin:aggs-matrix-stats-client:7.3.2
-- org.elasticsearch.plugin:parent-join-client:7.3.2
-- org.elasticsearch.plugin:rank-eval-client:7.3.2
+- org.apache.lucene:lucene-analyzers-common:8.3.0
+- org.apache.lucene:lucene-backward-codecs:8.3.0
+- org.apache.lucene:lucene-core:8.3.0
+- org.apache.lucene:lucene-grouping:8.3.0
+- org.apache.lucene:lucene-highlighter:8.3.0
+- org.apache.lucene:lucene-join:8.3.0
+- org.apache.lucene:lucene-memory:8.3.0
+- org.apache.lucene:lucene-misc:8.3.0
+- org.apache.lucene:lucene-queries:8.3.0
+- org.apache.lucene:lucene-queryparser:8.3.0
+- org.apache.lucene:lucene-sandbox:8.3.0
+- org.apache.lucene:lucene-spatial:8.3.0
+- org.apache.lucene:lucene-spatial-extras:8.3.0
+- org.apache.lucene:lucene-spatial3d:8.3.0
+- org.apache.lucene:lucene-suggest:8.3.0
+- org.elasticsearch:elasticsearch:7.5.1
+- org.elasticsearch:elasticsearch-cli:7.5.1
+- org.elasticsearch:elasticsearch-core:7.5.1
+- org.elasticsearch:elasticsearch-secure-sm:7.5.1
+- org.elasticsearch:elasticsearch-x-content:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-client:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.5.1
+- org.elasticsearch.plugin:aggs-matrix-stats-client:7.5.1
+- org.elasticsearch.plugin:lang-mustache-client:7.5.1
Review comment:
OK, Got it. I referenced the dependency tree before. Will remove it now.
```
- org.elasticsearch.plugin:lang-mustache-client:7.5.1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#discussion_r367363001
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -15,31 +15,33 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.httpcomponents:httpasyncclient:4.1.4
- org.apache.httpcomponents:httpclient:4.5.3
- org.apache.httpcomponents:httpcore:4.4.6
-- org.apache.httpcomponents:httpcore-nio:4.4.11
+- org.apache.httpcomponents:httpcore-nio:4.4.12
- org.apache.logging.log4j:log4j-api:2.11.1
- org.apache.logging.log4j:log4j-to-slf4j:2.11.1
-- org.apache.lucene:lucene-analyzers-common:8.1.0
-- org.apache.lucene:lucene-backward-codecs:8.1.0
-- org.apache.lucene:lucene-core:8.1.0
-- org.apache.lucene:lucene-grouping:8.1.0
-- org.apache.lucene:lucene-highlighter:8.1.0
-- org.apache.lucene:lucene-join:8.1.0
-- org.apache.lucene:lucene-memory:8.1.0
-- org.apache.lucene:lucene-misc:8.1.0
-- org.apache.lucene:lucene-queries:8.1.0
-- org.apache.lucene:lucene-queryparser:8.1.0
-- org.apache.lucene:lucene-sandbox:8.1.0
-- org.apache.lucene:lucene-spatial:8.1.0
-- org.apache.lucene:lucene-spatial-extras:8.1.0
-- org.apache.lucene:lucene-spatial3d:8.1.0
-- org.apache.lucene:lucene-suggest:8.1.0
-- org.elasticsearch:elasticsearch:7.3.2
-- org.elasticsearch:elasticsearch-cli:7.3.2
-- org.elasticsearch:elasticsearch-core:7.3.2
-- org.elasticsearch:elasticsearch-secure-sm:7.3.2
-- org.elasticsearch:elasticsearch-x-content:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-client:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.2
-- org.elasticsearch.plugin:aggs-matrix-stats-client:7.3.2
-- org.elasticsearch.plugin:parent-join-client:7.3.2
-- org.elasticsearch.plugin:rank-eval-client:7.3.2
+- org.apache.lucene:lucene-analyzers-common:8.3.0
+- org.apache.lucene:lucene-backward-codecs:8.3.0
+- org.apache.lucene:lucene-core:8.3.0
+- org.apache.lucene:lucene-grouping:8.3.0
+- org.apache.lucene:lucene-highlighter:8.3.0
+- org.apache.lucene:lucene-join:8.3.0
+- org.apache.lucene:lucene-memory:8.3.0
+- org.apache.lucene:lucene-misc:8.3.0
+- org.apache.lucene:lucene-queries:8.3.0
+- org.apache.lucene:lucene-queryparser:8.3.0
+- org.apache.lucene:lucene-sandbox:8.3.0
+- org.apache.lucene:lucene-spatial:8.3.0
+- org.apache.lucene:lucene-spatial-extras:8.3.0
+- org.apache.lucene:lucene-spatial3d:8.3.0
+- org.apache.lucene:lucene-suggest:8.3.0
+- org.elasticsearch:elasticsearch:7.5.1
+- org.elasticsearch:elasticsearch-cli:7.5.1
+- org.elasticsearch:elasticsearch-core:7.5.1
+- org.elasticsearch:elasticsearch-secure-sm:7.5.1
+- org.elasticsearch:elasticsearch-x-content:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-client:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.5.1
+- org.elasticsearch.plugin:aggs-matrix-stats-client:7.5.1
+- org.elasticsearch.plugin:lang-mustache-client:7.5.1
Review comment:
Why did you add `mustache-client` here? I think the rest of the dependencies look correct but about this one I don't know. It doesn't appear in the list of jars that are shaded in when I run `mvn clean install -DskipTests -Dfast`. In the ES7 SQL connector module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on a change in pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#discussion_r367366327
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -15,31 +15,33 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.httpcomponents:httpasyncclient:4.1.4
- org.apache.httpcomponents:httpclient:4.5.3
- org.apache.httpcomponents:httpcore:4.4.6
-- org.apache.httpcomponents:httpcore-nio:4.4.11
+- org.apache.httpcomponents:httpcore-nio:4.4.12
- org.apache.logging.log4j:log4j-api:2.11.1
- org.apache.logging.log4j:log4j-to-slf4j:2.11.1
-- org.apache.lucene:lucene-analyzers-common:8.1.0
-- org.apache.lucene:lucene-backward-codecs:8.1.0
-- org.apache.lucene:lucene-core:8.1.0
-- org.apache.lucene:lucene-grouping:8.1.0
-- org.apache.lucene:lucene-highlighter:8.1.0
-- org.apache.lucene:lucene-join:8.1.0
-- org.apache.lucene:lucene-memory:8.1.0
-- org.apache.lucene:lucene-misc:8.1.0
-- org.apache.lucene:lucene-queries:8.1.0
-- org.apache.lucene:lucene-queryparser:8.1.0
-- org.apache.lucene:lucene-sandbox:8.1.0
-- org.apache.lucene:lucene-spatial:8.1.0
-- org.apache.lucene:lucene-spatial-extras:8.1.0
-- org.apache.lucene:lucene-spatial3d:8.1.0
-- org.apache.lucene:lucene-suggest:8.1.0
-- org.elasticsearch:elasticsearch:7.3.2
-- org.elasticsearch:elasticsearch-cli:7.3.2
-- org.elasticsearch:elasticsearch-core:7.3.2
-- org.elasticsearch:elasticsearch-secure-sm:7.3.2
-- org.elasticsearch:elasticsearch-x-content:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-client:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.2
-- org.elasticsearch.plugin:aggs-matrix-stats-client:7.3.2
-- org.elasticsearch.plugin:parent-join-client:7.3.2
-- org.elasticsearch.plugin:rank-eval-client:7.3.2
+- org.apache.lucene:lucene-analyzers-common:8.3.0
+- org.apache.lucene:lucene-backward-codecs:8.3.0
+- org.apache.lucene:lucene-core:8.3.0
+- org.apache.lucene:lucene-grouping:8.3.0
+- org.apache.lucene:lucene-highlighter:8.3.0
+- org.apache.lucene:lucene-join:8.3.0
+- org.apache.lucene:lucene-memory:8.3.0
+- org.apache.lucene:lucene-misc:8.3.0
+- org.apache.lucene:lucene-queries:8.3.0
+- org.apache.lucene:lucene-queryparser:8.3.0
+- org.apache.lucene:lucene-sandbox:8.3.0
+- org.apache.lucene:lucene-spatial:8.3.0
+- org.apache.lucene:lucene-spatial-extras:8.3.0
+- org.apache.lucene:lucene-spatial3d:8.3.0
+- org.apache.lucene:lucene-suggest:8.3.0
+- org.elasticsearch:elasticsearch:7.5.1
+- org.elasticsearch:elasticsearch-cli:7.5.1
+- org.elasticsearch:elasticsearch-core:7.5.1
+- org.elasticsearch:elasticsearch-secure-sm:7.5.1
+- org.elasticsearch:elasticsearch-x-content:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-client:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.5.1
+- org.elasticsearch.plugin:aggs-matrix-stats-client:7.5.1
+- org.elasticsearch.plugin:lang-mustache-client:7.5.1
Review comment:
I run `mvn dependency:tree` and it shows this plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha merged pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on a change in pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#discussion_r367392695
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -15,31 +15,33 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.httpcomponents:httpasyncclient:4.1.4
- org.apache.httpcomponents:httpclient:4.5.3
- org.apache.httpcomponents:httpcore:4.4.6
-- org.apache.httpcomponents:httpcore-nio:4.4.11
+- org.apache.httpcomponents:httpcore-nio:4.4.12
- org.apache.logging.log4j:log4j-api:2.11.1
- org.apache.logging.log4j:log4j-to-slf4j:2.11.1
-- org.apache.lucene:lucene-analyzers-common:8.1.0
-- org.apache.lucene:lucene-backward-codecs:8.1.0
-- org.apache.lucene:lucene-core:8.1.0
-- org.apache.lucene:lucene-grouping:8.1.0
-- org.apache.lucene:lucene-highlighter:8.1.0
-- org.apache.lucene:lucene-join:8.1.0
-- org.apache.lucene:lucene-memory:8.1.0
-- org.apache.lucene:lucene-misc:8.1.0
-- org.apache.lucene:lucene-queries:8.1.0
-- org.apache.lucene:lucene-queryparser:8.1.0
-- org.apache.lucene:lucene-sandbox:8.1.0
-- org.apache.lucene:lucene-spatial:8.1.0
-- org.apache.lucene:lucene-spatial-extras:8.1.0
-- org.apache.lucene:lucene-spatial3d:8.1.0
-- org.apache.lucene:lucene-suggest:8.1.0
-- org.elasticsearch:elasticsearch:7.3.2
-- org.elasticsearch:elasticsearch-cli:7.3.2
-- org.elasticsearch:elasticsearch-core:7.3.2
-- org.elasticsearch:elasticsearch-secure-sm:7.3.2
-- org.elasticsearch:elasticsearch-x-content:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-client:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.2
-- org.elasticsearch.plugin:aggs-matrix-stats-client:7.3.2
-- org.elasticsearch.plugin:parent-join-client:7.3.2
-- org.elasticsearch.plugin:rank-eval-client:7.3.2
+- org.apache.lucene:lucene-analyzers-common:8.3.0
+- org.apache.lucene:lucene-backward-codecs:8.3.0
+- org.apache.lucene:lucene-core:8.3.0
+- org.apache.lucene:lucene-grouping:8.3.0
+- org.apache.lucene:lucene-highlighter:8.3.0
+- org.apache.lucene:lucene-join:8.3.0
+- org.apache.lucene:lucene-memory:8.3.0
+- org.apache.lucene:lucene-misc:8.3.0
+- org.apache.lucene:lucene-queries:8.3.0
+- org.apache.lucene:lucene-queryparser:8.3.0
+- org.apache.lucene:lucene-sandbox:8.3.0
+- org.apache.lucene:lucene-spatial:8.3.0
+- org.apache.lucene:lucene-spatial-extras:8.3.0
+- org.apache.lucene:lucene-spatial3d:8.3.0
+- org.apache.lucene:lucene-suggest:8.3.0
+- org.elasticsearch:elasticsearch:7.5.1
+- org.elasticsearch:elasticsearch-cli:7.5.1
+- org.elasticsearch:elasticsearch-core:7.5.1
+- org.elasticsearch:elasticsearch-secure-sm:7.5.1
+- org.elasticsearch:elasticsearch-x-content:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-client:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.5.1
+- org.elasticsearch.plugin:aggs-matrix-stats-client:7.5.1
+- org.elasticsearch.plugin:lang-mustache-client:7.5.1
Review comment:
Thanks, I think this is good to merge now! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574591161
<!--
Meta data
Hash:f4506ad0e9302a279940670fa90c305c240b3c12 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f4506ad0e9302a279940670fa90c305c240b3c12
-->
## CI report:
* f4506ad0e9302a279940670fa90c305c240b3c12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#issuecomment-574583824
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f4506ad0e9302a279940670fa90c305c240b3c12 (Wed Jan 15 09:56:26 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15558).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on a change in pull request #10861:
[FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for
es7 connector
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #10861: [FLINK-15558][Connector] Bump Elasticsearch version from 7.3.2 to 7.5.1 for es7 connector
URL: https://github.com/apache/flink/pull/10861#discussion_r367392420
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -15,31 +15,33 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.httpcomponents:httpasyncclient:4.1.4
- org.apache.httpcomponents:httpclient:4.5.3
- org.apache.httpcomponents:httpcore:4.4.6
-- org.apache.httpcomponents:httpcore-nio:4.4.11
+- org.apache.httpcomponents:httpcore-nio:4.4.12
- org.apache.logging.log4j:log4j-api:2.11.1
- org.apache.logging.log4j:log4j-to-slf4j:2.11.1
-- org.apache.lucene:lucene-analyzers-common:8.1.0
-- org.apache.lucene:lucene-backward-codecs:8.1.0
-- org.apache.lucene:lucene-core:8.1.0
-- org.apache.lucene:lucene-grouping:8.1.0
-- org.apache.lucene:lucene-highlighter:8.1.0
-- org.apache.lucene:lucene-join:8.1.0
-- org.apache.lucene:lucene-memory:8.1.0
-- org.apache.lucene:lucene-misc:8.1.0
-- org.apache.lucene:lucene-queries:8.1.0
-- org.apache.lucene:lucene-queryparser:8.1.0
-- org.apache.lucene:lucene-sandbox:8.1.0
-- org.apache.lucene:lucene-spatial:8.1.0
-- org.apache.lucene:lucene-spatial-extras:8.1.0
-- org.apache.lucene:lucene-spatial3d:8.1.0
-- org.apache.lucene:lucene-suggest:8.1.0
-- org.elasticsearch:elasticsearch:7.3.2
-- org.elasticsearch:elasticsearch-cli:7.3.2
-- org.elasticsearch:elasticsearch-core:7.3.2
-- org.elasticsearch:elasticsearch-secure-sm:7.3.2
-- org.elasticsearch:elasticsearch-x-content:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-client:7.3.2
-- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.3.2
-- org.elasticsearch.plugin:aggs-matrix-stats-client:7.3.2
-- org.elasticsearch.plugin:parent-join-client:7.3.2
-- org.elasticsearch.plugin:rank-eval-client:7.3.2
+- org.apache.lucene:lucene-analyzers-common:8.3.0
+- org.apache.lucene:lucene-backward-codecs:8.3.0
+- org.apache.lucene:lucene-core:8.3.0
+- org.apache.lucene:lucene-grouping:8.3.0
+- org.apache.lucene:lucene-highlighter:8.3.0
+- org.apache.lucene:lucene-join:8.3.0
+- org.apache.lucene:lucene-memory:8.3.0
+- org.apache.lucene:lucene-misc:8.3.0
+- org.apache.lucene:lucene-queries:8.3.0
+- org.apache.lucene:lucene-queryparser:8.3.0
+- org.apache.lucene:lucene-sandbox:8.3.0
+- org.apache.lucene:lucene-spatial:8.3.0
+- org.apache.lucene:lucene-spatial-extras:8.3.0
+- org.apache.lucene:lucene-spatial3d:8.3.0
+- org.apache.lucene:lucene-suggest:8.3.0
+- org.elasticsearch:elasticsearch:7.5.1
+- org.elasticsearch:elasticsearch-cli:7.5.1
+- org.elasticsearch:elasticsearch-core:7.5.1
+- org.elasticsearch:elasticsearch-secure-sm:7.5.1
+- org.elasticsearch:elasticsearch-x-content:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-client:7.5.1
+- org.elasticsearch.client:elasticsearch-rest-high-level-client:7.5.1
+- org.elasticsearch.plugin:aggs-matrix-stats-client:7.5.1
+- org.elasticsearch.plugin:lang-mustache-client:7.5.1
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services