You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by StevenMPhillips <gi...@git.apache.org> on 2015/12/03 22:42:40 UTC
[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...
GitHub user StevenMPhillips opened a pull request:
https://github.com/apache/drill/pull/289
DRILL-4159: Use test framework in TestCsvHeader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StevenMPhillips/drill master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #289
----
commit f4e34ccac6add649df469f85e38f064962eae90a
Author: Steven Phillips <sm...@apache.org>
Date: 2015-12-03T21:39:03Z
DRILL-4159: Use test framework in TestCsvHeader
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...
Posted by vkorukanti <gi...@git.apache.org>.
Github user vkorukanti commented on the pull request:
https://github.com/apache/drill/pull/289#issuecomment-161794179
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/289#issuecomment-161818595
The one that is generating a string representation of the result set, which caused the bug. getResultString()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...
Posted by StevenMPhillips <gi...@git.apache.org>.
Github user StevenMPhillips commented on the pull request:
https://github.com/apache/drill/pull/289#issuecomment-161816994
Which method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/289#issuecomment-161813807
As long as you are changing it do you want to remove the two test classes still using this method and then just delete it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...
Posted by StevenMPhillips <gi...@git.apache.org>.
Github user StevenMPhillips commented on the pull request:
https://github.com/apache/drill/pull/289#issuecomment-161800836
I didn't do a full build with tests before merging, and it looks like there is a checkstyle problem.
I fixed it, and am now doing a full build to verify before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---