You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/05/27 05:03:49 UTC
Review Request 34686: [WinTP2] ServiceConfig should not log password
in plaintext
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34686/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, and Jayush Luniya.
Bugs: AMBARI-11403
https://issues.apache.org/jira/browse/AMBARI-11403
Repository: ambari
Description
-------
Fixed logged string generation
Diffs
-----
ambari-common/src/main/python/resource_management/core/base.py 67634cdf884ffff0d019df5da3d9ba4ce5335e87
ambari-common/src/main/python/resource_management/core/logger.py 74e88e89786855b84b64f6bd3cf22d89561bada4
ambari-common/src/main/python/resource_management/core/resources/service.py cb202cf041161e0911edca07ca5c12789f77d513
Diff: https://reviews.apache.org/r/34686/diff/
Testing
-------
local cluster deployment -> cluster install -> passwords hidden ok
Thanks,
Florian Barca
Re: Review Request 34686: [WinTP2] ServiceConfig should not log
password in plaintext
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34686/#review85316
-----------------------------------------------------------
Make sure you validate your changes on Linux
ambari-common/src/main/python/resource_management/core/logger.py
<https://reviews.apache.org/r/34686/#comment136874>
This is going to break ambari/ambari-common/src/main/python/resource_management/core/shell.py
log_msg = Logger.get_function_repr("{0}['{1}']".format(function.__name__, command_alias), kwargs)
- Jayush Luniya
On May 27, 2015, 3:03 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34686/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 3:03 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, and Jayush Luniya.
>
>
> Bugs: AMBARI-11403
> https://issues.apache.org/jira/browse/AMBARI-11403
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed logged string generation
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/base.py 67634cdf884ffff0d019df5da3d9ba4ce5335e87
> ambari-common/src/main/python/resource_management/core/logger.py 74e88e89786855b84b64f6bd3cf22d89561bada4
> ambari-common/src/main/python/resource_management/core/resources/service.py cb202cf041161e0911edca07ca5c12789f77d513
>
> Diff: https://reviews.apache.org/r/34686/diff/
>
>
> Testing
> -------
>
> local cluster deployment -> cluster install -> passwords hidden ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 34686: [WinTP2] ServiceConfig should not log
password in plaintext
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34686/#review85446
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Baranchuk
On Май 27, 2015, 4:01 п.п., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34686/
> -----------------------------------------------------------
>
> (Updated Май 27, 2015, 4:01 п.п.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, and Jayush Luniya.
>
>
> Bugs: AMBARI-11403
> https://issues.apache.org/jira/browse/AMBARI-11403
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed logged string generation
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/base.py 67634cdf884ffff0d019df5da3d9ba4ce5335e87
> ambari-common/src/main/python/resource_management/core/logger.py 74e88e89786855b84b64f6bd3cf22d89561bada4
> ambari-common/src/main/python/resource_management/core/resources/service.py cb202cf041161e0911edca07ca5c12789f77d513
>
> Diff: https://reviews.apache.org/r/34686/diff/
>
>
> Testing
> -------
>
> local cluster deployment -> cluster install -> passwords hidden ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 34686: [WinTP2] ServiceConfig should not log
password in plaintext
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34686/
-----------------------------------------------------------
(Updated May 27, 2015, 4:01 p.m.)
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, and Jayush Luniya.
Changes
-------
Fixed Logger refactoring.
Bugs: AMBARI-11403
https://issues.apache.org/jira/browse/AMBARI-11403
Repository: ambari
Description
-------
Fixed logged string generation
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/core/base.py 67634cdf884ffff0d019df5da3d9ba4ce5335e87
ambari-common/src/main/python/resource_management/core/logger.py 74e88e89786855b84b64f6bd3cf22d89561bada4
ambari-common/src/main/python/resource_management/core/resources/service.py cb202cf041161e0911edca07ca5c12789f77d513
Diff: https://reviews.apache.org/r/34686/diff/
Testing
-------
local cluster deployment -> cluster install -> passwords hidden ok
Thanks,
Florian Barca