[GitHub] [arrow] zeroshade commented on a change in pull request #12009: ARROW-15172: [Go] Add Arm64 Neon implementation for Arrow-math

[GitBox <gi...@apache.org>]

zeroshade commented on a change in pull request #12009:
URL: https://github.com/apache/arrow/pull/12009#discussion_r778217652



##########
File path: go/arrow/math/Makefile
##########
@@ -37,27 +41,42 @@ INTEL_SOURCES := \
 	int64_avx2_amd64.s int64_sse4_amd64.s \
 	uint64_avx2_amd64.s uint64_sse4_amd64.s
 
+ARM_SOURCES := \
+	float64_neon_arm64.s \
+	int64_neon_arm64.s \
+	uint64_neon_arm64.s
+
 .PHONEY: assembly
 
-assembly: $(INTEL_SOURCES)
+#ifeq ($(GOARCH), arm64)
+assembly: $(ARM_SOURCES)
+#else
+#assembly: $(INTEL_SOURCES)
+#endif
 

Review comment:
       Does this only work if you're currently *on* arm64? I believe Go has arguments and env vars which allow for creating / building cross platform, is it possible to build the ARM sources for Arm64 neon without having to be on an arm64 neon machine? Either way, can we have comments or the readme updated with whatever instructions / requirements are needed to generate the arm64 sources?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org