You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by de...@apache.org on 2006/06/06 07:46:01 UTC
svn commit: r412012 -
/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Author: dennisbyrne
Date: Mon Jun 5 22:46:00 2006
New Revision: 412012
URL: http://svn.apache.org/viewvc?rev=412012&view=rev
Log:
should reduce mailing list traffic
Modified:
myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Modified: myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java?rev=412012&r1=412011&r2=412012&view=diff
==============================================================================
--- myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java (original)
+++ myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java Mon Jun 5 22:46:00 2006
@@ -206,7 +206,12 @@
FormInfo formInfo = findNestingForm(component, facesContext);
if (formInfo == null)
{
- throw new IllegalArgumentException("Component " + clientId + " must be embedded in an form");
+ String path = RendererUtils.getPathToComponent(component);
+ String msg = "Change component/tag '" + clientId + "' from javax.faces.*/<h:tagName /> " +
+ "to org.apache.myfaces.*/<t:tagName />, or embed it in a form. This is not a bug. " +
+ " MyFaces core implementation no longer supports formless action sources in order to " +
+ "make your application more inter-operable with the RI. The path to this component is " + path ;
+ throw new IllegalArgumentException(msg);
}
UIComponent nestingForm = formInfo.getForm();
String formName = formInfo.getFormName();
Re: svn commit: r412012 - /myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Sean!
> Yes we should have a "Upgrading to Tomahawk 1.1.3" wiki. If someone
> writes it I will be sure to link to it in the release notes.
http://wiki.apache.org/myfaces/Upgrading_to_Tomahawk_1.1.3
I changed the exception in shared accordingly.
Ciao,
Mario
Re: svn commit: r412012 - /myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Posted by Sean Schofield <se...@gmail.com>.
Yes we should have a "Upgrading to Tomahawk 1.1.3" wiki. If someone
writes it I will be sure to link to it in the release notes.
Sean
On 6/6/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi!
> > + String msg = "Change component/tag '" + clientId + "' from javax.faces.*/<h:tagName /> " +
> > + "to org.apache.myfaces.*/<t:tagName />, or embed it in a form. This is not a bug. " +
> > + " MyFaces core implementation no longer supports formless action sources in order to " +
> > + "make your application more inter-operable with the RI. The path to this component is " +
> Shouldn't we setup a wiki or documentation on how to reenable the
> dummyForm stuff in MyFaces only environments and point the user to this
> page in this exception message?
> I think we should show them that we provide a slow migration away from
> dummyForm.
>
> Ciao,
> Mario
>
>
Re: svn commit: r412012 - /myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
> + String msg = "Change component/tag '" + clientId + "' from javax.faces.*/<h:tagName /> " +
> + "to org.apache.myfaces.*/<t:tagName />, or embed it in a form. This is not a bug. " +
> + " MyFaces core implementation no longer supports formless action sources in order to " +
> + "make your application more inter-operable with the RI. The path to this component is " +
Shouldn't we setup a wiki or documentation on how to reenable the
dummyForm stuff in MyFaces only environments and point the user to this
page in this exception message?
I think we should show them that we provide a slow migration away from
dummyForm.
Ciao,
Mario