You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/10 02:42:57 UTC

[GitHub] [rocketmq] ph3636 opened a new pull request #2792: optimize: add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

ph3636 opened a new pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on a change in pull request #2792: optimize: add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792#discussion_r613098337



##########
File path: client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AbstractAllocateMessageQueueStrategy.java
##########
@@ -0,0 +1,57 @@
+package org.apache.rocketmq.client.consumer.rebalance;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.rocketmq.client.consumer.AllocateMessageQueueStrategy;
+import org.apache.rocketmq.client.log.ClientLogger;
+import org.apache.rocketmq.common.message.MessageQueue;
+import org.apache.rocketmq.logging.InternalLogger;
+
+/**
+ * @author ph3636
+ */

Review comment:
       Remove Author information

##########
File path: client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AbstractAllocateMessageQueueStrategy.java
##########
@@ -0,0 +1,57 @@
+package org.apache.rocketmq.client.consumer.rebalance;

Review comment:
       Lack of apache license header




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #2792: optimize: add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792#issuecomment-819385900


   Plz create an issue before you submit a pull request


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ph3636 commented on pull request #2792: [ISSUE #2809] Add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

Posted by GitBox <gi...@apache.org>.
ph3636 commented on pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792#issuecomment-844665870


   > Plz create an issue before you submit a pull request
   
   ok,@RongtongJin PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2792: optimize: add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792#issuecomment-817067210


   
   [![Coverage Status](https://coveralls.io/builds/38696532/badge)](https://coveralls.io/builds/38696532)
   
   Coverage increased (+0.1%) to 52.036% when pulling **3fb25ee81b7c9715c4eb9e6b08e62a6151cb31af on ph3636:AbstractAllocateMessageQueueStrategy** into **7680063f89a2aa5ae003f5d19ebd3343e828b94f on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2792: [ISSUE #2809] Add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792#issuecomment-817067210


   
   [![Coverage Status](https://coveralls.io/builds/38835587/badge)](https://coveralls.io/builds/38835587)
   
   Coverage decreased (-0.03%) to 51.9% when pulling **8e7996b3d230cc3c448f9fa67b9243269ee51b0d on ph3636:AbstractAllocateMessageQueueStrategy** into **7680063f89a2aa5ae003f5d19ebd3343e828b94f on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ph3636 commented on a change in pull request #2792: [ISSUE #2809] Add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

Posted by GitBox <gi...@apache.org>.
ph3636 commented on a change in pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792#discussion_r613726366



##########
File path: client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AbstractAllocateMessageQueueStrategy.java
##########
@@ -0,0 +1,57 @@
+package org.apache.rocketmq.client.consumer.rebalance;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.rocketmq.client.consumer.AllocateMessageQueueStrategy;
+import org.apache.rocketmq.client.log.ClientLogger;
+import org.apache.rocketmq.common.message.MessageQueue;
+import org.apache.rocketmq.logging.InternalLogger;
+
+/**
+ * @author ph3636
+ */

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ph3636 commented on a change in pull request #2792: [ISSUE #2809] Add AbstractAllocateMessageQueueStrategy Optimize AllocateMessageQueueStrategy code

Posted by GitBox <gi...@apache.org>.
ph3636 commented on a change in pull request #2792:
URL: https://github.com/apache/rocketmq/pull/2792#discussion_r613726401



##########
File path: client/src/main/java/org/apache/rocketmq/client/consumer/rebalance/AbstractAllocateMessageQueueStrategy.java
##########
@@ -0,0 +1,57 @@
+package org.apache.rocketmq.client.consumer.rebalance;

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org