You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/06/08 20:06:08 UTC
[jira] Created: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
addauth fails to register auth on new client that's not yet connected
---------------------------------------------------------------------
Key: ZOOKEEPER-438
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
Project: Zookeeper
Issue Type: Bug
Components: c client, java client
Reporter: Patrick Hunt
Priority: Blocker
Fix For: 3.2.0
if addauth is called on a new client connection that's never connected to the server, when the client does connect
(syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-438:
------------------------------------
Status: Open (was: Patch Available)
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-438:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. thanks ben.
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-438:
------------------------------------
Attachment: ZOOKEEPER-438.patch
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-438:
------------------------------------
Status: Patch Available (was: Open)
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-438:
-----------------------------------
Attachment: ZOOKEEPER-438.patch
this patch includes a test that shows the problem. I'm not certain how to fix it though.
Also, it seems like access to authInfo should be synchronized - since multiple threads are potentially
accessing it at the same time (client & sendthread for example)
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724837#action_12724837 ]
Hudson commented on ZOOKEEPER-438:
----------------------------------
Integrated in ZooKeeper-trunk #359 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/359/])
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-438:
--------------------------------------
Assignee: Benjamin Reed (was: Patrick Hunt)
Ben can you take a look at this? The basic problem is that the authinfo is sent to
the server during primeconnection, if the client adds auth after this, but before the
connection is fully established, the authinfo is not transmitted to the server until
the next reconnect.
We should verify the c client as well.
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723898#action_12723898 ]
Hadoop QA commented on ZOOKEEPER-438:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12411719/ZOOKEEPER-438.patch
against trunk revision 788238.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/134/console
This message is automatically generated.
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-438:
------------------------------------
Attachment: ZOOKEEPER-438.patch
slightly out of date
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-438:
------------------------------------
Status: Patch Available (was: Open)
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-438:
------------------------------------
Attachment: ZOOKEEPER-438.patch
the last patch failed on ant test with compilation eroor. this fixes the issue. I ran the tests and it passes. +1 for the patch ...
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch, ZOOKEEPER-438.patch
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-438) addauth fails to register auth on
new client that's not yet connected
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-438:
--------------------------------------
Assignee: Patrick Hunt
> addauth fails to register auth on new client that's not yet connected
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-438
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-438
> Project: Zookeeper
> Issue Type: Bug
> Components: c client, java client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.0
>
>
> if addauth is called on a new client connection that's never connected to the server, when the client does connect
> (syncconnected) the auth is not passed to the server. we should ensure we addauth when the client connects or reconnects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.