You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by mnogu <gi...@git.apache.org> on 2014/04/19 08:10:15 UTC
[GitHub] incubator-storm pull request: STORM-286: Use URLEncoder#encode wit...
GitHub user mnogu opened a pull request:
https://github.com/apache/incubator-storm/pull/79
STORM-286: Use URLEncoder#encode with the encoding specified.
We should set the name of character encoding to UTF-8 explicitly
because URLEncoder#encode without the encoding parameter is deprecated
and the W3C states that UTF-8 should be used according to Java API docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mnogu/incubator-storm avoid-deprecated-encode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit a1871e5557e8770d5be73691ebdca75a83cb993d
Author: Muneyuki Noguchi <no...@gmail.com>
Date: 2014-04-19T04:13:15Z
Use URLEncoder#encode with the encoding specified.
We should set the name of character encoding to UTF-8 explicitly
because URLEncoder#encode without the encoding parameter is deprecated
and the W3C states that UTF-8 should be used according to Java API docs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-286: Use URLEncoder#encode wit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-286: Use URLEncoder#encode wit...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/79#issuecomment-41299310
@mnogu, this doesn't merge cleanly. Can you sync with the master branch and resolve conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-286: Use URLEncoder#encode wit...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/79#issuecomment-40946752
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-286: Use URLEncoder#encode wit...
Posted by mnogu <gi...@git.apache.org>.
Github user mnogu commented on the pull request:
https://github.com/apache/incubator-storm/pull/79#issuecomment-41306085
I updated the branch. Could you try this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-286: Use URLEncoder#encode wit...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/79#issuecomment-41194174
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---