You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/09 16:22:29 UTC

[GitHub] [beam] aaltay commented on a change in pull request #11353: [BEAM-9726] Make region optional for non-service runner.

aaltay commented on a change in pull request #11353: [BEAM-9726] Make region optional for non-service runner.
URL: https://github.com/apache/beam/pull/11353#discussion_r406322401
 
 

 ##########
 File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
 ##########
 @@ -224,6 +225,9 @@
    */
   public static final String PROJECT_ID_REGEXP = "[a-z][-a-z0-9:.]+[a-z0-9]";
 
+  /** Dataflow service endpoints are expected to match this pattern. */
+  static final String ENDPOINT_REGEXP = "https://[\\S]*googleapis\\.com[/]?";
 
 Review comment:
   Is this always true? (I do not know the answer but probably good to check wrt staging etc. endpoints.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services