You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/25 08:09:16 UTC
[GitHub] [hive] szlta opened a new pull request #2315: HIVE-25160: Automatically pass on iceberg-handler jar as job dependency
szlta opened a new pull request #2315:
URL: https://github.com/apache/hive/pull/2315
Currently users are required to run the ADD JAR command in their session if they want to use Iceberg tables in Hive jobs.
This should be done in an automatic way similarly to how hbase-, kudu-, .. etc handlers are doing it.
Options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2315: HIVE-25160: Automatically pass on iceberg-handler jar as job dependency
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2315:
URL: https://github.com/apache/hive/pull/2315#discussion_r638616249
##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -158,6 +164,37 @@ public void configureJobConf(TableDesc tableDesc, JobConf jobConf) {
jobConf.set(InputFormatConfig.TABLE_CATALOG_PREFIX + tableName, catalogName);
}
}
+ try {
+ addDependencyJars(jobConf, HiveIcebergStorageHandler.class);
+ } catch (IOException e) {
+ Throwables.propagate(e);
+ }
+ }
+
+ // Copied from the KuduStorageHandler :)
Review comment:
Maybe refactor it to somewhere common?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta merged pull request #2315: HIVE-25160: Automatically pass on iceberg-handler jar as job dependency
Posted by GitBox <gi...@apache.org>.
szlta merged pull request #2315:
URL: https://github.com/apache/hive/pull/2315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org