You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/09 19:09:20 UTC
Review Request 13442: Fixed slave to not re-register with master in cleanup
mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13442/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-631
https://issues.apache.org/jira/browse/MESOS-631
Repository: mesos-git
Description
-------
I might kill/disable 'cleanup' soon. In the meanwhile, this is the right thing for "cleanup" to do.
Diffs
-----
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8
Diff: https://reviews.apache.org/r/13442/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13442: Fixed slave to not re-register with master in
cleanup mode.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13442/
-----------------------------------------------------------
(Updated Aug. 13, 2013, 10:44 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. nnfr.
Bugs: MESOS-631
https://issues.apache.org/jira/browse/MESOS-631
Repository: mesos-git
Description
-------
I might kill/disable 'cleanup' soon. In the meanwhile, this is the right thing for "cleanup" to do.
Diffs (updated)
-----
src/slave/slave.cpp dbc4473d37d6581f488ec39b7b7dcb5936935e6f
src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8
Diff: https://reviews.apache.org/r/13442/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13442: Fixed slave to not re-register with master in
cleanup mode.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13442/#review24938
-----------------------------------------------------------
Ship it!
Can you document what this means for posterity? As in, if a master fails over while the slave is disconnected in cleanup mode, the new master will not forward the updates and the slave will retry forever (can be fixed with registrar)?
- Ben Mahler
On Aug. 9, 2013, 5:09 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13442/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 5:09 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-631
> https://issues.apache.org/jira/browse/MESOS-631
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I might kill/disable 'cleanup' soon. In the meanwhile, this is the right thing for "cleanup" to do.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
> src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8
>
> Diff: https://reviews.apache.org/r/13442/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>