You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2020/02/17 11:17:00 UTC
[jira] [Commented] (FLINK-16117) Avoid register source in
TableTestBase#addTableSource
[ https://issues.apache.org/jira/browse/FLINK-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038256#comment-17038256 ]
Jark Wu commented on FLINK-16117:
---------------------------------
I think we should use {{TableTestBase#addTable(ddl)}} in all tests.
> Avoid register source in TableTestBase#addTableSource
> -----------------------------------------------------
>
> Key: FLINK-16117
> URL: https://issues.apache.org/jira/browse/FLINK-16117
> Project: Flink
> Issue Type: Sub-task
> Reporter: Zhenghua Gao
> Priority: Major
>
> This affects thousands of unit tests:
> 1) explainSourceAsString of CatalogSourceTable changes
> 2)JoinTest#testUDFInJoinCondition: SQL keywords must be escaped
> 3) GroupWindowTest#testTimestampEventTimeTumblingGroupWindowWithProperties: Reference to a rowtime or proctime window required
> 4) SetOperatorsTest#testInWithProject: legacy type vs new type
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)