You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "H145608 (via GitHub)" <gi...@apache.org> on 2026/05/20 04:23:14 UTC
[PR] [DOCS] Add missing setNamesrvAddr in Chinese Example_Delay.md [rocketmq]
H145608 opened a new pull request, #10362:
URL: https://github.com/apache/rocketmq/pull/10362
Add the missing setNamesrvAddr() calls in consumer and producer setup code examples to align with the English version and other Chinese example files.
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
- Fixes #issue_id
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] Add missing setNamesrvAddr in Chinese Example_Delay.md [rocketmq]
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on code in PR #10362:
URL: https://github.com/apache/rocketmq/pull/10362#discussion_r3294389394
##########
docs/cn/Example_Delay.md:
##########
@@ -15,6 +15,8 @@ public class ScheduledMessageConsumer {
public static void main(String[] args) throws Exception {
// Instantiate message consumer
DefaultMQPushConsumer consumer = new DefaultMQPushConsumer("ExampleConsumer");
+ // 设置NameServer地址
Review Comment:
Use English comments here to match the existing code style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] Add missing setNamesrvAddr in Chinese Example_Delay.md [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10362:
URL: https://github.com/apache/rocketmq/pull/10362#issuecomment-4505838607
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10362?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.85%. Comparing base ([`a3abd51`](https://app.codecov.io/gh/apache/rocketmq/commit/a3abd5185a18f9c05a6eaec0a5aa0afb3279bf44?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`040ef31`](https://app.codecov.io/gh/apache/rocketmq/commit/040ef31e5e23d9dc52ab9eb168e9710082404abd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10362 +/- ##
=============================================
- Coverage 48.97% 48.85% -0.13%
+ Complexity 13473 13438 -35
=============================================
Files 1375 1375
Lines 100452 100452
Branches 12973 12973
=============================================
- Hits 49197 49076 -121
- Misses 45265 45366 +101
- Partials 5990 6010 +20
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/10362?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org